Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basket with AMD module system #167

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Implement basket with AMD module system #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bbf668
1. Implement basket with amd module system, so that:
normanzb May 5, 2016
df67443
update the test to workaround the compatibility issue between compact…
normanzb May 5, 2016
7d7eed9
fix require compatibility issue with qunit
normanzb May 6, 2016
5c576eb
upgrade compact-promise to latest
normanzb May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 69 additions & 8 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,58 @@
module.exports = function( grunt ) {
'use strict';

function getHandleModuleBundleComplete(start, end) {
return function handleModuleBundleComplete (data) {
var fs = require('fs'),
amdclean = require('amdclean'),
outputFile = data.path;

fs.writeFileSync(outputFile, amdclean.clean({
filePath: outputFile,
prefixMode: 'camelCase',
'wrap': {
'start': start,
'end': end
}
}));
};
}

grunt.initConfig({
pkg: grunt.file.readJSON('package.json'),
requirejs : {
dist : {
options : {
baseUrl: '.',
include: 'lib/basket.js',
out: 'dist/basket.js',
optimize : 'none',
onModuleBundleComplete: getHandleModuleBundleComplete(';(function(){','return libBasketjs})();')
}
},
full: {
options : {
paths: {
'lib/RSVP.wrapper': 'bower_components/compact-promise/src/Defer'
},
baseUrl: '.',
include: 'lib/basket.js',
out: 'dist/basket.full.js',
optimize : 'none',
onModuleBundleComplete: getHandleModuleBundleComplete('', '')
}
}
},
umd: {
full: {
options: {
src: 'dist/basket.full.js',
dest: 'dist/basket.full.js',
globalAlias: 'basket',
objectToExport: 'libBasketjs'
}
}
},
concat: {
options: {
banner: '/*!\n' +
Expand All @@ -14,13 +64,17 @@ module.exports = function( grunt ) {
' <%= _.pluck(pkg.licenses, "type").join(", ") %> License\n' +
'* Created by: <%= _.pluck(pkg.maintainers, "name").join(", ") %>\n' +
'* Contributors: <%= _.pluck(pkg.contributors, "name").join(", ") %>\n' +
'* Uses rsvp.js, https://github.com/tildeio/rsvp.js\n' +
'* Uses rsvp.js, https://github.com/tildeio/rsvp.js or compact-promise\n' +
'*/',
stripBanners: true
},
dist: {
src: ['lib/basket.js'],
src: ['dist/basket.js'],
dest: 'dist/basket.js'
},
full: {
src: ['dist/basket.full.js'],
dest: 'dist/basket.full.js'
}
},
uglify: {
Expand All @@ -41,14 +95,19 @@ module.exports = function( grunt ) {
sourceMap: 'dist/basket.full.map'
},
files: {
'dist/basket.full.min.js': ['bower_components/rsvp/rsvp.min.js', 'dist/basket.js']
'dist/basket.full.min.js': ['dist/basket.full.js']
}
}
},
qunit: {
all: {
modular: {
options: {
urls: ['http://localhost:8080/test/index.html']
urls: ['http://localhost:8080/test/modular.html']
}
},
bundled: {
options: {
urls: ['http://localhost:8080/test/bundled.html']
}
}
},
Expand All @@ -59,7 +118,7 @@ module.exports = function( grunt ) {
}
},
connect: {
server: {
all: {
options: {
base: '.',
port: 8080
Expand All @@ -80,13 +139,15 @@ module.exports = function( grunt ) {
grunt.loadNpmTasks('grunt-contrib-qunit');
grunt.loadNpmTasks('grunt-contrib-connect');
grunt.loadNpmTasks('grunt-contrib-watch');
grunt.loadNpmTasks('grunt-contrib-requirejs');
grunt.loadNpmTasks('grunt-umd');

// Dev - default
grunt.registerTask('default', ['test']);

// Release
grunt.registerTask('release', ['test', 'concat', 'uglify']);
grunt.registerTask('release', ['test', 'requirejs', 'umd', 'concat', 'uglify', 'qunit:bundled']);

//Tests
grunt.registerTask('test', ['jshint', 'connect', 'qunit']);
grunt.registerTask('test', ['jshint', 'connect', 'qunit:modular']);
};
5 changes: 5 additions & 0 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,10 @@
],
"dependencies": {
"rsvp": "~3.0.16"
},
"devDependencies": {
"compact-promise": "~1.1.7",
"requirejs": "~2.2.0",
"qunit": "^1.20.0"
}
}
Loading