Implement basket with AMD module system #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Its easier for AMD user to use the source code version of basket.js (simply `require(['pathtobasket/src/basket'])`) 3. The basket.full.js became much much smaller than before 5k vs 11k(original), because of swapping out RSVP with compact-promise 4. Support UMD header so everyone gets benefit? 5. The standalone basket doesn't get bloated too much by this change (around 0.1k)
…-promise and rsvp
|
for some reason travis just doesn't happy with my gruntfile, will try fix it later |
|
travis issue fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.20KB (now, minified) v.s. 14.6 KB(when it is with RSVP, minified)
(simply
require(['pathtobasket/src/basket']))By doing this change, the standalone basket doesn't get bloated too much by this change
(3.2KB now v.s. 3.1KB previously)