Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added notify and drawer default CSS animations #531

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix: Added notify and drawer default CSS animations #531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b389bf
Fix: Added notify and drawer default CSS animations
oliverfoster Oct 29, 2024
5bcc989
CSS Defaults
oliverfoster Oct 29, 2024
bcfc501
Drawer shadow animation
oliverfoster Oct 29, 2024
f7c894f
Change classes from open/close to show/hide
oliverfoster Oct 29, 2024
08b58c8
Update durations and easing
swashbuck Oct 30, 2024
48809d9
Rename drawer duration variable
swashbuck Oct 31, 2024
b6baec7
Add --adapt-notify-duration CSS prop
swashbuck Oct 31, 2024
2c27f45
Change drawer show/hide easing to use CSS variables
swashbuck Dec 11, 2024
f0697ec
Remove transform transition as it is not being used
swashbuck Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion less/core/drawer.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}

.drawer:not(.disable-animation) {
.transition(left @duration ease-in, right @duration ease-in, transform @duration ease-in, opacity @duration ease-in;);
.transition(left var(--drawerDuration) @animation-easing, right var(--drawerDuration) @animation-easing, transform var(--drawerDuration) @animation-easing, opacity var(--drawerDuration) @animation-easing;);
oliverfoster marked this conversation as resolved.
Show resolved Hide resolved
opacity: 0;

&.is-position-auto,
Expand Down
4 changes: 2 additions & 2 deletions less/core/notify.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@


.notify:not(.disable-animation) > .notify__popup {
.transition(margin-top @duration, top @duration, transform @duration ease-in, opacity @duration ease-in, height @duration ease-in;);
.transition(margin-top 0.4s @animation-easing, top 0.4s @animation-easing, transform 0.4s @animation-easing, opacity 0.4s @animation-easing, height 0.4s @animation-easing;);
opacity: 0;
transform: translateY(0%);

Expand All @@ -124,7 +124,7 @@
}

.notify:not(.disable-animation) > .notify__shadow {
.transition(opacity @duration ease-in;);
.transition(opacity 0.4s @animation-easing;);
opacity: 0;

.anim-show-after& {
Expand Down