Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added notify and drawer default CSS animations #531

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix: Added notify and drawer default CSS animations #531

wants to merge 9 commits into from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Oct 29, 2024 •
edited
Loading

part of adaptlearning/adapt-contrib-core#600
requires adaptlearning/adapt-contrib-core#601

New

  • Added default notify and drawer css animations

@oliverfoster oliverfoster self-assigned this Oct 29, 2024
oliverfoster
oliverfoster commented Oct 30, 2024
View reviewed changes
less/core/drawer.less Outdated Show resolved Hide resolved
@swashbuck swashbuck mentioned this pull request Oct 31, 2024
Open
@oliverfoster oliverfoster marked this pull request as ready for review December 10, 2024 16:21
@oliverfoster
Copy link
Member Author

oliverfoster commented Dec 10, 2024 •
edited
Loading

@swashbuck would you be able to use the easing properties --adapt-drawer-show-easing, --adapt-drawer-hide-easing where applicable, instead of @animation-easing please?

@swashbuck
Copy link
Contributor

@swashbuck would you be able to use the easing properties --adapt-drawer-show-easing, --adapt-drawer-hide-easing where applicable, instead of @animation-easing please?

Yep, done.

@oliverfoster
Copy link
Member Author

👍

swashbuck
swashbuck approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool @lemmyadams