Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue 198 return metrics after initialisation of repertoires #203

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix: issue 198 return metrics after initialisation of repertoires #203

wants to merge 1 commit into from

Conversation

hannah-jan
Copy link
Collaborator

@hannah-jan hannah-jan commented Oct 1, 2024 •
edited by Lookatator
Loading

Related issues: Issue #198

Return metrics after initialisation of repertoires.

This PR introduces:

  • returning of metrics after initialisation of repertoires
  • updates to notebooks/tests to be compatible with this

@hannah-jan hannah-jan changed the title Fix/issue 198 Fix: issue 198 return metrics after initialisation of repertoires Oct 1, 2024
@Lookatator Lookatator changed the base branch from main to develop October 1, 2024 13:06
@Lookatator Lookatator self-requested a review October 6, 2024 12:43
Lookatator
Lookatator requested changes Oct 6, 2024
View reviewed changes
Copy link
Member

@Lookatator Lookatator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 😃 It seems the init_metrics are not used in the python notebooks. Do you think we should add them to the all_metrics dictionary, and logged in the csv_logger? (this way they would appear on the plot in the end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lookatator Lookatator Lookatator requested changes

Assignees

@hannah-jan hannah-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannah-jan @Lookatator