Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: libraries installation in Colab notebooks #193

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

Lookatator
Copy link
Member

This PR fixes the problem of dependencies in Colab notebooks by installing qdax[cuda12] at the top of every notebook

It also fixes the description of the DCRL algorithm in its notebook.

You can use this link to test the fixed DCRL notebook.

Checks

  • N/A a clear description of the PR has been added
  • N/A sufficient tests have been written
  • N/A relevant section added to the documentation
  • N/A example notebook added to the repo
  • N/A clean docstrings and comments have been written
  • N/A if any issue/observation has been discovered, a new issue has been opened

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (8c9d2ec) to head (a27fb7c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files         128      128           
  Lines        7983     7983           
=======================================
  Hits         7385     7385           
  Misses        598      598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lookatator Lookatator merged commit f16b0da into main Sep 9, 2024
5 checks passed
@Lookatator Lookatator deleted the hotfix/notebook-installs branch September 13, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants