Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up codebase - standardize terminology and random key usage #190

Merged
merged 17 commits into from
Sep 23, 2024
Merged

Clean up codebase - standardize terminology and random key usage #190

merged 17 commits into from
Sep 23, 2024

Conversation

maxencefaldor
Copy link
Member

@maxencefaldor maxencefaldor commented Sep 3, 2024 •
edited by Lookatator
Loading

  • Unify descriptor naming from "bd", "BD", "behavior_descriptor" to "descriptor".
  • Stop returning random keys to follow JAX guidelines.
  • Rename all random_key to key.
  • Remove Brax scoring function with init_states as arguments (and use reset_based_scoring_function_brax_envs instead, which has been renamed to scoring_function_brax_envs)
  • Remove examples/scripts/ directory
  • Rename all arguments named "unused" by "_"

@Lookatator Lookatator added this to the v0.5.0 milestone Sep 5, 2024
@Lookatator Lookatator added enhancement New feature or request refactoring labels Sep 5, 2024
@maxencefaldor maxencefaldor changed the title Improve naming and handling of random keys Cleaning Sep 22, 2024
Lookatator
Lookatator requested changes Sep 22, 2024
View reviewed changes
qdax/tasks/brax_envs.py Outdated Show resolved Hide resolved
qdax/tasks/jumanji_envs.py Outdated Show resolved Hide resolved
@Lookatator Lookatator removed this from the v0.5.0 milestone Sep 23, 2024
@Lookatator Lookatator changed the title Cleaning Clean up codebase - standardize terminology and random key usage Sep 23, 2024
@Lookatator Lookatator merged commit f38884c into develop Sep 23, 2024
9 checks passed
@Lookatator Lookatator deleted the feat/clean branch September 27, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lookatator Lookatator Lookatator approved these changes

Assignees

@maxencefaldor maxencefaldor

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxencefaldor @Lookatator