-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use brax.v1 and update requirements #156
use brax.v1 and update requirements #156
Conversation
…#149) fix: dependencies in notebook examples
Also update dev.Dockerfile micromamba and python
Is any QDax maintainer able to help move this forward? |
Hi @DBraun, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me overall!
To run the PR tests and make it possible to compile the docs and run the automated pipeline, could you:
- merge
develop
into your branch? - and change the version of python in the
.readthedocs.yaml
to3.9
?
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #156 +/- ##
========================================
Coverage 92.23% 92.23%
========================================
Files 120 120
Lines 6992 6992
========================================
Hits 6449 6449
Misses 543 543
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
df954c2
into
adaptive-intelligent-robotics:develop
Related issues: #155
Where necessary I've changed
brax
tobrax.v1
. This is a short-term solution becausev1
is already deprecated. However, it at least gets QDax working with jax/jaxlib 0.4.16 and flax 0.7.4. At the moment, if you install QDax from scratch without previously installing jax/flax, you end up with an unusable flax/qdax. This fixes that.This PR is really just a starting point for discussion. I have installed it locally and imported various QDax things which work fine.
Checks
Future improvements
In the future QDax should not use brax.v1. Someone could make this a new issue soon.