-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(API): Apply gas mark up to base fee rather than gas cost #1339
Open
nicholaspai
wants to merge
42
commits into
master
Choose a base branch
from
gas-markup-fee
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+179
−43
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
1a21394
improve(API): Apply gas mark up to base fee rather than gas cost
nicholaspai eaf7fd8
Update _utils.ts
nicholaspai ed22e76
Update _utils.ts
nicholaspai 00a4557
Update _utils.ts
nicholaspai cb6b690
Update limits.ts
nicholaspai cdde913
Update _utils.ts
nicholaspai 396d62b
3.4.1 sdk
nicholaspai 8cf8072
Merge branch 'master' into gas-markup-fee
nicholaspai 99b5da2
Update _utils.ts
nicholaspai eb77db9
Update _utils.ts
nicholaspai ea0a94d
Merge branch 'master' into gas-markup-fee
nicholaspai ed05490
3.4.3
nicholaspai 769296d
Update _utils.ts
nicholaspai 6a524ac
improve(API): Add gas costs to /gas-prices endpoint
nicholaspai 0113ac5
Merge branch 'gas-costs' into gas-markup-fee
nicholaspai 3044ca9
Add gas costs to api
nicholaspai 099d72b
Merge branch 'gas-costs' into gas-markup-fee
nicholaspai 18c3641
Update _utils.ts
nicholaspai c9a3481
Update gas-prices.ts
nicholaspai 75254f6
Update _utils.ts
nicholaspai 6f2bcf3
Update gas-prices.ts
nicholaspai 051be80
Remove reading from cache
nicholaspai 7f4f2a8
Update gas-prices.ts
nicholaspai bbfbe1b
Merge branch 'gas-costs' into gas-markup-fee
nicholaspai 5fb79b9
Update gas-prices.ts
nicholaspai 6948d14
Update gas-prices.ts
nicholaspai 752704c
Allow caller to set token symbol
nicholaspai 868d76b
Update gas-prices.ts
nicholaspai 7d91801
Update gas-prices.ts
nicholaspai 47fa488
Update gas-prices.ts
nicholaspai 5f6a1c5
Return full gas price broken down
nicholaspai 2ffb6a6
Update gas-prices.ts
nicholaspai f10a8e9
Update gas-prices.ts
nicholaspai fc08217
Update gas-prices.ts
nicholaspai 9fe1b31
Update gas-prices.ts
nicholaspai 24c2bbd
Add op stack gas cost
nicholaspai 207397d
refactor
nicholaspai ca704ea
Revert "refactor"
nicholaspai e48b4f9
Revert "Add op stack gas cost"
nicholaspai 894c141
Reapply "Add op stack gas cost"
nicholaspai 0f3d4f2
Try op stack l1 gas cost again
nicholaspai cd4dd7e
Update gas-prices.ts
nicholaspai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One difference here. In the current multiplier use case, the SDK adds the
gasMarkup
to 1 here.Whereas, the new SDK change I propose assumes that the passed in multiplier is complete already and doesn't need to be added to anything