improve(API): Apply gas mark up to base fee rather than gas cost #1339

nicholaspai · 2024-12-19T20:07:10Z

We can test this by querying /api/gas-prices against the same endpoint on the prod deployment. This will show roughly how the gas costs will change with prod.

Ultimately, what matters is the gasFeeTotal in the /limits end point and we should compare with prod.

For WETH:
query /limits for every single destination chain once on Prod API and once on Preview API
Write down the gasFeeTotal and compare with Preview API
Note any differences:
If Prod API has higher gas fee total, then preview API will reduce gas fees but we need to make sure these gas fees are still deemed profitable by relayer
If preview API has higher gas fee total, then that’s notable as well

Results

Example GAS_MARKUP on the API: {"1": 0.05, "10": 1.0, "137": 2.0, "288": 1.0, "324": 0.01, "480": 1.0, "8453": 0.8, "42161": 1.0, "59144": 0.2, "34443": 1.0, "81457": 1.0, "534352": 1.0, "690": 1.0, "7777777": 1.0}
137: limits?destinationChainId=137&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is 3/2 higher in Prod API than Preview API. This is because the maxFeePerGas in Preview API is larger than Prod API but the Polygon GAS_MARKUP = 3 and in the preview API its only applied to the baseFee where in Prod API its applied to the full tokenGasCost = gasCost * maxFeePerGas
1: limits?destinationChainId=1&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is 1.17x higher in Prod API
10: limits?destinationChainId=10&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is 2x higher in Prod API
8453: limits?destinationChainId=8453&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is the same
534352: limits?destinationChainId=534352&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is the same
324: limits?destinationChainId=324&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is the same
59144: limits?destinationChainId=59144&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is 2x higher in Prod API
- This is probably explained mostly by the fact we're using the NEW_GAS_ORACLE env var in the Preview API which gives much lower gas fees
1135: limits?destinationChainId=1135&token=0x82aF49447D8a07e3bd95BD0d56f35241523fBab1
- gasFeeTotal is 1.8x higher in Prod API
42161: limits?destinationChainId=42161&token=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
- gasFeeTotal is 1.9x higher in Prod API
41455: limits?destinationChainId=41455&token=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
- gasFeeTotal is the same
690: limits?destinationChainId=690&token=0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
- gasFeeTotal is 2x higher in Prod API

vercel · 2024-12-19T20:07:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-frontend-v3	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 0:42am
sepolia-frontend-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 0:42am

james-a-morris

We should let integrators know about this prior to rolling out. This will change expected fees

api/_utils.ts

nicholaspai · 2025-01-02T17:11:59Z

api/_utils.ts

-    : DEFAULT_GAS_MARKUP;
+  return (
+    1 +
+    (sdk.utils.chainIsOPStack(Number(chainId))


One difference here. In the current multiplier use case, the SDK adds the gasMarkup to 1 here.

Whereas, the new SDK change I propose assumes that the passed in multiplier is complete already and doesn't need to be added to anything

nicholaspai · 2025-01-03T20:14:06Z

api/_utils.ts

@@ -1966,13 +1969,12 @@ export function latestGasPriceCache(chainId: number) {
 * @returns The gas price in the native currency of the chain
 */
 export async function getMaxFeePerGas(chainId: number): Promise<BigNumber> {
-  if (sdk.utils.chainIsOPStack(chainId)) {


Important LOC we're removing. We should use gas price oracle for all estimates since it handles OP stack now

nicholaspai · 2025-01-03T20:54:25Z

Note: because this PR uses the SDK's GasPriceOracle to compute gas prices even for OpStack chains we should NOT MERGE this PR until we set the GAS_PRICE_EIP1559_RAW_ variables equal to true (and probably also the NEW_GAS_PRICE_ORACLE_59144 ). Otherwise the API will give higher gas price estimates than we use currently

Signed-off-by: nicholaspai <[email protected]>

improve(API): Apply gas mark up to base fee rather than gas cost

1a21394

nicholaspai requested review from dohaki, james-a-morris and pxrl December 19, 2024 20:07

james-a-morris reviewed Dec 20, 2024

View reviewed changes

Update _utils.ts

eaf7fd8

vercel bot had a problem deploying to Preview – sepolia-frontend-v2 December 27, 2024 14:58 Failure

vercel bot had a problem deploying to Preview – app-frontend-v3 December 27, 2024 14:58 Failure

nicholaspai commented Dec 27, 2024

View reviewed changes

api/_utils.ts Show resolved Hide resolved

nicholaspai mentioned this pull request Dec 27, 2024

feat(gasPriceOracle): Allow caller to pass in base fee multiplier across-protocol/sdk#801

Merged

nicholaspai commented Jan 2, 2025

View reviewed changes

Update _utils.ts

ed22e76

vercel bot had a problem deploying to Preview – app-frontend-v3 January 2, 2025 23:26 Failure

vercel bot had a problem deploying to Preview – sepolia-frontend-v2 January 2, 2025 23:26 Failure

Update _utils.ts

00a4557

vercel bot had a problem deploying to Preview – app-frontend-v3 January 2, 2025 23:35 Failure

vercel bot had a problem deploying to Preview – sepolia-frontend-v2 January 2, 2025 23:35 Failure

Update limits.ts

cb6b690

vercel bot had a problem deploying to Preview – sepolia-frontend-v2 January 3, 2025 00:01 Failure

vercel bot had a problem deploying to Preview – app-frontend-v3 January 3, 2025 00:01 Failure

Update _utils.ts

cdde913

vercel bot had a problem deploying to Preview – app-frontend-v3 January 3, 2025 00:15 Failure

vercel bot had a problem deploying to Preview – sepolia-frontend-v2 January 3, 2025 00:15 Failure

nicholaspai added 3 commits January 3, 2025 11:28

3.4.1 sdk

396d62b

Merge branch 'master' into gas-markup-fee

8cf8072

Update _utils.ts

99b5da2

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 16:49 View deployment

nicholaspai marked this pull request as ready for review January 3, 2025 16:52

nicholaspai requested a review from mrice32 as a code owner January 3, 2025 16:52

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 16:54 View deployment

nicholaspai requested a review from gsteenkamp89 January 3, 2025 17:53

Update _utils.ts

eb77db9

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 19:49 View deployment

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 19:49 View deployment

nicholaspai commented Jan 3, 2025

View reviewed changes

nicholaspai added 2 commits January 3, 2025 15:20

Merge branch 'master' into gas-markup-fee

ea0a94d

3.4.3

ed05490

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 20:34 View deployment

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 20:36 View deployment

Update _utils.ts

769296d

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 20:47 View deployment

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 20:47 View deployment

nicholaspai added the do not merge label Jan 3, 2025

nicholaspai added 2 commits January 3, 2025 17:59

improve(API): Add gas costs to /gas-prices endpoint

6a524ac

Signed-off-by: nicholaspai <[email protected]>

Merge branch 'gas-costs' into gas-markup-fee

0113ac5

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 23:06 View deployment

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 23:12 View deployment

nicholaspai added 2 commits January 3, 2025 18:16

Add gas costs to api

3044ca9

Merge branch 'gas-costs' into gas-markup-fee

099d72b

vercel bot deployed to Preview – sepolia-frontend-v2 January 3, 2025 23:23 View deployment

vercel bot deployed to Preview – app-frontend-v3 January 3, 2025 23:28 View deployment

Update _utils.ts

18c3641

vercel bot deployed to Preview – sepolia-frontend-v2 January 4, 2025 00:32 View deployment

vercel bot deployed to Preview – app-frontend-v3 January 4, 2025 00:32 View deployment

Update gas-prices.ts

c9a3481

vercel bot deployed to Preview – app-frontend-v3 January 4, 2025 00:42 View deployment

vercel bot deployed to Preview – sepolia-frontend-v2 January 4, 2025 00:42 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve(API): Apply gas mark up to base fee rather than gas cost #1339

improve(API): Apply gas mark up to base fee rather than gas cost #1339

nicholaspai commented Dec 19, 2024 •

edited

Loading

vercel bot commented Dec 19, 2024 •

edited

Loading

james-a-morris left a comment

nicholaspai Jan 2, 2025

nicholaspai Jan 3, 2025

nicholaspai commented Jan 3, 2025

improve(API): Apply gas mark up to base fee rather than gas cost #1339

Are you sure you want to change the base?

improve(API): Apply gas mark up to base fee rather than gas cost #1339

Conversation

nicholaspai commented Dec 19, 2024 • edited Loading

Results

vercel bot commented Dec 19, 2024 • edited Loading

james-a-morris left a comment

Choose a reason for hiding this comment

nicholaspai Jan 2, 2025

Choose a reason for hiding this comment

nicholaspai Jan 3, 2025

Choose a reason for hiding this comment

nicholaspai commented Jan 3, 2025

nicholaspai commented Dec 19, 2024 •

edited

Loading

vercel bot commented Dec 19, 2024 •

edited

Loading