test: Added tests for Base_SpokePool.sol #818
Open
+74
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Signed-off-by: Dhruv-Varshney-Developer <[email protected]>
Dhruv-Varshney-developer
force-pushed
the
documentation-updates
branch
from
0e5d10f to
c630e21
Compare
11 tasks
|
Hi @mrice32 @nicholaspai @chrismaree @pxrl, |
nicholaspai
reviewed
Dec 31, 2024
nicholaspai
reviewed
Dec 31, 2024
nicholaspai
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Actually, can you address the no-missing-import and no-missing-require issues rather than disable warnings on them?
https://github.com/across-protocol/contracts/pull/818/files#r1900274196
Signed-off-by: Dhruv-Varshney-developer <[email protected]>
Dhruv-Varshney-developer
requested review from
mrice32,
chrismaree,
Reinis-FRP,
md0x,
pxrl and
bmzig
as code owners
Signed-off-by: Dhruv-Varshney-developer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base_SpokePool.sollacked test coverage, which could lead to potential issues. This PR ensures that the functionality is well-tested and behaves as expected. Additionally, small improvements to the documentation enhance clarity and professionalism, while ESLint warning adjustments streamline development.Code Changes Overview:
test/evm/hardhat/chain-specific-spokepools/Base_SpokePool.ts, covering initialization and error scenarios.README.mdfor spelling corrections and slight formatting improvements.Please let me know if improvements are needed in the PR!
You can learn more about me here.