Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(test): Added tests for AlephZero_SpokePool.sol #824

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Dhruv-Varshney-developer

This PR continues the effort to address the missing test coverage identified in #822 .

Description

  • AlephZeroSpokePool.sol lacked test coverage, which could lead to potential issues. This PR adds comprehensive tests to ensure the functionality behaves as expected and improves overall reliability.

Code Changes Overview

  • Added tests in test/evm/hardhat/chain-specific-spokepools/AlephZero_SpokePool.ts, covering initialization.

Hi @mrice32, @nicholaspai, @chrismaree, @pxrl, @Reinis-FRP, and @bmzig,
Your feedback on this PR would be greatly appreciated. Let me know if any improvements are needed.

Learn more about me here.

Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. I think the higher priority spoke pools to get coverage for are those with more bespoke logic, like the WorldChain_SpokePool and Ink_SpokePool which have special _bridgeTokensToHubPool logic as well as the Blast_SpokePool which has special logic to handle USDB.

Do you want to take a crack at that next?

Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruv-Varshney-developer
Copy link
Author

Nice PR. I think the higher priority spoke pools to get coverage for are those with more bespoke logic, like the WorldChain_SpokePool and Ink_SpokePool which have special _bridgeTokensToHubPool logic as well as the Blast_SpokePool which has special logic to handle USDB.

Do you want to take a crack at that next?

Thanks for the review @nicholaspai!
Yes, I'll take a look at those next and create a PR as soon as I am done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants