Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split telemetry into parse, validate and execution #1172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split telemetry into parse, validate and execution #1172

wants to merge 1 commit into from
+60 −18

Commits on May 25, 2022

  1. Split telemetry into parse, validate and execution 

    This get a bit closer to what we see in other implementations, like the
javascript one, where we have explicit phases for parse and validation.

This way, we can instrument Absinthe in a similar fashion, and break
down how much work is done inside the framework (by parse/validation)
and by the execution engine itself (and resolvers). Example of those
phases in [Apollo Federation + JS impl][1].

[1]: https://www.apollographql.com/docs/federation/opentelemetry/#graphql-specific-spans
    @andrewhr
    andrewhr committed May 25, 2022
    Configuration menu
    Copy the full SHA
    5354c91 View commit details
    Browse the repository at this point in the history