Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible section list items #288

Merged
merged 3 commits into from
Sep 19, 2023
Merged

More flexible section list items #288

merged 3 commits into from
Sep 19, 2023

Conversation

devgioele
Copy link
Contributor

@devgioele devgioele commented Sep 19, 2023

No description provided.

@devgioele devgioele self-assigned this Sep 19, 2023
@devgioele devgioele requested a review from alexlanz September 19, 2023 13:49
@github-actions
Copy link

Preview link: https://288.react-ui.aboutbits.dev

base: 'flex border-b border-neutral-200 last:border-0 items-center min-h-[3.5rem] bg-white px-4 md:px-6',
base: 'flex border-b border-neutral-200 last:border-0 items-center py-4 bg-white px-4 md:px-6',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change so that we are free to decide the height. Whether all items in the list have the same height, is the responsibility of who builds the list.

@devgioele devgioele merged commit 6f0b184 into main Sep 19, 2023
4 checks passed
@devgioele devgioele deleted the section-list-items-2 branch September 19, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants