Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded section list items #287

Closed
wants to merge 2 commits into from
Closed

Expanded section list items #287

wants to merge 2 commits into from

Conversation

devgioele
Copy link
Contributor

Adds a new layout to SectionListItemButton and SectionListItemLink, where the chevron longer and bottom-anchored.

@devgioele devgioele self-assigned this Sep 19, 2023
@devgioele devgioele requested a review from alexlanz September 19, 2023 12:30
@github-actions
Copy link

Preview link: https://287.react-ui.aboutbits.dev

@@ -28,67 +30,96 @@ export type SectionListItemButtonProps = ClassNameProps & {
*/
onClick: () => void
children?: ReactNode
variant?: SectionListItemLayout
badge?: ReactNode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a better name than badge? We commonly place a badge here, but any ReactNode goes

Copy link
Member

@alexlanz alexlanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the call, we would now try to hide the icon using a flag and then such design adjustments can be done in the project itself.

@devgioele
Copy link
Contributor Author

As discussed in the call, we would now try to hide the icon using a flag and then such design adjustments can be done in the project itself.

Closing this in favor of #288

@devgioele devgioele closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants