Update geocoder_api.py #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the geocoding functionality in the GeocoderApi class to accommodate scenarios where only partial address information, such as city and postcode, is available. Currently, the address_with_details method raises errors when incomplete address details are provided. As most of the companies are from scrapped data or hubspot and full address is not available, we can't create new companies in the DirectoryCompany table.
herepy/geocoder_api.py
Outdated
| house_number: int, | ||
| street: str, | ||
| house_number: Optional[int] = None, | ||
| street: Optional[str] = None, |
There was a problem hiding this comment.
Add the optional parameters after the required parameters to fix the linting issues
fix linting issues
| city: str, | ||
| country: str, | ||
| lang: str = "en-US", | ||
| house_number: Optional[int] = None, | ||
| street: Optional[str] = None, |
| @@ -129,11 +129,16 @@ def address_with_details( | |||
| Raises: | |||
| HEREError""" | |||
|
|
|||
| qq_query = "" | |||
| if house_number is not None: | |||
| qq_query += f"houseNumber={house_number};" | |||
There was a problem hiding this comment.
Can you add new test cases to cover the optional parameters?
| if house_number is not None: | ||
| qq_query += f"houseNumber={house_number};" | ||
| if street is not None: | ||
| qq_query += f"street={street};" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 93.22% 93.24% +0.02%
==========================================
Files 26 26
Lines 1726 1733 +7
==========================================
+ Hits 1609 1616 +7
Misses 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for adding new test cases, looks good! |
thank you for the quick response ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have upgrade the geocoding functionality in the GeocoderApi class to accommodate scenarios where only partial address information, such as city and postcode, is available. Currently, the address_with_details method raises errors when incomplete address details are provided.