Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geocoder_api.py to handle optional city, country and postal code #81

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Hazurl
Copy link

@Hazurl Hazurl commented Jun 6, 2024

As in #77, this PR extends address_with_details:

  • city is now optional
  • country is now optional
  • postal_code has been added
  • If nothing is provided (since now all parameters can be optional), raise an error before doing a request that would be rejected
  • Treat empty strings as None because here will fail anyway

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (cffef39) to head (0d75cf8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   92.96%   92.98%   +0.02%     
==========================================
  Files          26       26              
  Lines        1749     1754       +5     
==========================================
+ Hits         1626     1631       +5     
  Misses        123      123              
Flag Coverage Δ
unittests 92.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@abdullahselek abdullahselek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me.

@abdullahselek abdullahselek merged commit 4f373c4 into abdullahselek:master Jun 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants