Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile would not start up with weird line endings, add Docker instructions #1

Open
wants to merge 2 commits into
base: docker
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ RUN cd /root/gwc-release && bundle install
COPY setup_git.sh /usr/local/bin/setup_git.sh

# Make the script executable
RUN chmod +x /usr/local/bin/setup_git.sh
RUN dos2unix /usr/local/bin/setup_git.sh && \
chmod +x /usr/local/bin/setup_git.sh

# Set the script as the entrypoint
ENTRYPOINT ["/usr/local/bin/setup_git.sh"]
Expand Down
40 changes: 37 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# Andrea's docker image
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GWC release docker image


The ruby script used below for the automated release of GeoWebCache, relied on an old setup that was difficult to reproduce. This resulted in a small number of volunteers being able to release GWC, until Andrea created this docker image to ease the pain.

## Instructions for use

Check out the `docker` branch from https://github.com/aaime/gwc-release/tree/docker and enter this directory.

Build the image from the Dockerfile with:

`docker build -t gwc_release:0.1 .`

Run the image, passing in Git credentials as environment variables:

`docker run -it -v d:/tmp/m2:/root/.m2 -e GIT_USERNAME="user" -e GIT_EMAIL="[email protected]" gwc_release:0.1`

Note that the maven repository /root/.m2 is mapped to the host's d:/tmp/m2 for persistence.

Once started, one has to hand-edit the /root/.m2/settings.xml file to add the repo.osgeo.org credentials (OSGeo login, needs nexus permissions suitable for release: geoserver - geowebcache uses geoserver repo) (maybe we could make this also as part of the docker run command above?).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of mapping is a good one. It also means the settings.xml might already have the credentials, either from a previous run, or because they were configured for other projects (e.g., GeoTools/GeoServer).
So I'd use an hypothetical here.


Finally, in order to tag at the end, one needs to create a GitHub personal access token that will be used as the password for that step (go to your user settings, developer settings (right at the bottom, left), and create a personal access token). This could also be avoided by replacing with a step to copy over the identification certificate, and then checkout GWC using the ssh URL.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum... maybe map the certificate directory too, and then also checkout with SSH then?


### Now that docker is set up, you're ready to continue with:

This ruby script allows to automate the release of GeoWebCache.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks out of place now.


Requirements
------------

* Commit access to the https://github.com/GeoWebCache repo (team-geowebcache)
* GitHub personal access token
* repo.osgeo.org credentials (OSGeo login) with nexus permissions suitable for release: geoserver
* SourceForge credentials

Installation
------------

Expand Down Expand Up @@ -37,8 +69,8 @@ export EDITOR=vi
Also make sure xsddoc in in the path.


Releasing a stable release
--------------------------
Releasing a stable/maintenance release
--------------------------------------

Assuming one wants to release a GWC 1.9.3, which depends on GeoToools 15.4, then run the following commands:

Expand All @@ -61,7 +93,9 @@ ruby release.rb --branch 1.9.x --long-version 1.9.3 --short-version 1.9 --gt-ver
Creating a new branch
---------------------

Same as above, but with these instructions:
This is applicable when preparing the Release Candidate or .0 Initial release

Instead of the 4 ruby commands above, use these commands:

````
ruby release.rb --branch main reset
Expand Down