Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile would not start up with weird line endings, add Docker instructions #1

Open
wants to merge 2 commits into
base: docker
Choose a base branch
from
Open

Dockerfile would not start up with weird line endings, add Docker instructions #1

wants to merge 2 commits into from

Conversation

petersmythe
Copy link

Building upon GeoWebCache#13

@petersmythe
Copy link
Author

What is missing: where does one get the GWC changes for the release notes step from? Required for the

ruby release.rb .... --type candidate update step

@aaime
Copy link
Owner

aaime commented Sep 18, 2024 via email

@petersmythe petersmythe mentioned this pull request Sep 18, 2024
Open
aaime
aaime reviewed Sep 18, 2024
View reviewed changes
README.md
@@ -1,5 +1,37 @@
# Andrea's docker image
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GWC release docker image

README.md

Note that the maven repository /root/.m2 is mapped to the host's d:/tmp/m2 for persistence.

Once started, one has to hand-edit the /root/.m2/settings.xml file to add the repo.osgeo.org credentials (OSGeo login, needs nexus permissions suitable for release: geoserver - geowebcache uses geoserver repo) (maybe we could make this also as part of the docker run command above?).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of mapping is a good one. It also means the settings.xml might already have the credentials, either from a previous run, or because they were configured for other projects (e.g., GeoTools/GeoServer).
So I'd use an hypothetical here.

README.md

Once started, one has to hand-edit the /root/.m2/settings.xml file to add the repo.osgeo.org credentials (OSGeo login, needs nexus permissions suitable for release: geoserver - geowebcache uses geoserver repo) (maybe we could make this also as part of the docker run command above?).

Finally, in order to tag at the end, one needs to create a GitHub personal access token that will be used as the password for that step (go to your user settings, developer settings (right at the bottom, left), and create a personal access token). This could also be avoided by replacing with a step to copy over the identification certificate, and then checkout GWC using the ssh URL.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum... maybe map the certificate directory too, and then also checkout with SSH then?

README.md
Finally, in order to tag at the end, one needs to create a GitHub personal access token that will be used as the password for that step (go to your user settings, developer settings (right at the bottom, left), and create a personal access token). This could also be avoided by replacing with a step to copy over the identification certificate, and then checkout GWC using the ssh URL.

### Now that docker is set up, you're ready to continue with:

This ruby script allows to automate the release of GeoWebCache.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks out of place now.

@petersmythe
Copy link
Author

petersmythe commented Sep 18, 2024 •
edited
Loading

The scp part of the deploy step appears to be missing something in the docker image.

Error:

I, [2024-09-18T18:30:32.042750 #35282]  INFO -- git: Deploying artifacts to Sourceforge
E, [2024-09-18T18:30:33.850603 #35282] ERROR -- net.ssh.authentication.agent[4b0]: could not connect to ssh-agent: Agent not configured
Password:
Traceback (most recent call last):
        21: from release.rb:614:in `<main>'
        20: from release.rb:614:in `each'
        19: from release.rb:653:in `block in <main>'
        18: from release.rb:332:in `deploy_release'
        17: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh.rb:266:in `start'
        16: from release.rb:333:in `block in deploy_release'
        15: from /usr/local/bundle/gems/net-scp-4.0.0/lib/net/scp.rb:284:in `upload!'
        14: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/channel.rb:272:in `wait'
        13: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `loop'
        12: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `loop'
        11: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `block in loop'
        10: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:226:in `process'
         9: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:28:in `process'
         8: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:104:in `ev_preprocess'
         7: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:104:in `each'
         6: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:250:in `ev_preprocess'
         5: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:540:in `each_channel'
         4: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:540:in `each'
         3: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:250:in `block in ev_preprocess'
         2: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/channel.rb:325:in `process'
         1: from /usr/local/bundle/gems/net-scp-4.0.0/lib/net/scp.rb:369:in `block (3 levels) in start_command'
/usr/local/bundle/gems/net-scp-4.0.0/lib/net/scp.rb:398:in `await_response_state': \x01scp: /home/frs/project/geowebcache/geowebcache/1.26.0: Permission denied (Net::SCP::Error)
        19: from release.rb:614:in `<main>'
        18: from release.rb:614:in `each'
        17: from release.rb:653:in `block in <main>'
        16: from release.rb:332:in `deploy_release'
        15: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh.rb:268:in `start'
        14: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh.rb:268:in `ensure in start'
        13: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:125:in `close'
        12: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `loop'
        11: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `loop'
        10: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:179:in `block in loop'
         9: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:226:in `process'
         8: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:28:in `process'
         7: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:104:in `ev_preprocess'
         6: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/event_loop.rb:104:in `each'
         5: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:249:in `ev_preprocess'
         4: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:549:in `dispatch_incoming_packets'
         3: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:686:in `channel_close'
         2: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/session.rb:573:in `channel_closed'
         1: from /usr/local/bundle/gems/net-ssh-7.2.3/lib/net/ssh/connection/channel.rb:614:in `do_close'
/usr/local/bundle/gems/net-scp-4.0.0/lib/net/scp.rb:365:in `block (3 levels) in start_command': SCP did not finish successfully (1):  (Net::SCP::Error)
root@c6aa67253290:~/geowebcache#

I have confirmed that my SF creds are correct and log me in using WinSCP

@aaime
Copy link
Owner

aaime commented Sep 18, 2024 via email

@petersmythe
Copy link
Author

Says "permission denied" Il mer 18 set 2024, 20:41 Peter Smythe @.***> ha scritto:

Yes, that was the problem, thank you, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaime aaime aaime left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petersmythe @aaime