-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(runner): stop runner if test time exceeds the duration given (#53)
- Loading branch information
Showing
1 changed file
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
387b552
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes the test to fail and the results to become unavailable with "The test failed, there is no data to present. Please check test logs".
But I was doing a test with a single scenario with 2 simple GET requests.
Wouldn't it timeout often if some of the last requests of the scenario happens took more than RUNNER_TIMEOUT_GRACE_MS ?
The grace period should be at least configurable, 300ms is way too low.
I used for my test:
Duration: 10m
RPS: 1
Ramp to: 2
Parallelism: 1
I see someone already reported similar problem in #56