fix: rename bucket_sizes to buckets_sizes

Zooz · Dec 8, 2020 · e16a596 · e16a596
1 parent 0876d2b
commit e16a596
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/adapters/prometheusAdapter.js b/app/adapters/prometheusAdapter.js
@@ -12,8 +12,8 @@ module.exports.buildMetricsPlugin = (metricsConfig, jobConfig) => {
         }
     };
 
-    if (metricsConfig.bucket_sizes) {
-        prometheusPlugin.prometheus.bucketSizes = metricsConfig.bucket_sizes;
+    if (metricsConfig.buckets_sizes) {
+        prometheusPlugin.prometheus.bucketSizes = metricsConfig.buckets_sizes;
     }
 
     return prometheusPlugin;

diff --git a/tests/unit-tests/adapters/prometheusAdapter-test.js b/tests/unit-tests/adapters/prometheusAdapter-test.js
@@ -24,13 +24,13 @@ const expectedPluginConfiguartion = {
 };
 
 describe('Prometheus adapter test', () => {
-    it('Should retrieve prometheus plugin configuration without bucket_sizes or labels', () => {
+    it('Should retrieve prometheus plugin configuration without buckets_sizes or labels', () => {
         const pluginConfiguration = prometheusAdapter.buildMetricsPlugin(metricsConfig, jobConfig);
         should(pluginConfiguration).eql(expectedPluginConfiguartion);
     });
 
-    it('Should retrieve prometheus plugin configuration with bucket_sizes and labels', () => {
-        metricsConfig.bucket_sizes = [0.5, 1, 5, 10, 100];
+    it('Should retrieve prometheus plugin configuration with buckets_sizes and labels', () => {
+        metricsConfig.buckets_sizes = [0.5, 1, 5, 10, 100];
         metricsConfig.labels = { key1: 'value2', key2: 'value2' };
         const pluginConfiguration = prometheusAdapter.buildMetricsPlugin(metricsConfig, jobConfig);
         expectedPluginConfiguartion.prometheus.bucketSizes = [0.5, 1, 5, 10, 100];

diff --git a/tests/utils/consts.js b/tests/utils/consts.js
@@ -205,7 +205,7 @@ module.exports.EXPECTED_ARTILLERY_CUSTOM_TEST = {
 
 module.exports.PROMETHEUS_CONFIGURATION = {
     push_gateway_url: 'http://pushgateway.com',
-    bucket_sizes: [0.5, 1, 2, 5, 10]
+    buckets_sizes: [0.5, 1, 2, 5, 10]
 };
 
 module.exports.INFLUX_CONFIGURATION = {