Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onupdate retry validation #5

Closed
wants to merge 2 commits into from
Closed

Onupdate retry validation #5

wants to merge 2 commits into from

Conversation

atamon
Copy link
Contributor

@atamon atamon commented Feb 14, 2019

No description provided.

@solsson solsson mentioned this pull request Feb 18, 2019
Merged
@solsson
Copy link
Contributor

solsson commented Feb 18, 2019

We should merge #14 into this one, then retest and merge.

I think the initial tests/its that only verify that services are up should be moved to some helper that can run as a single it or before at the top of each spec. Promises would make sure that probes don't re-run.

@solsson
Copy link
Contributor

solsson commented Feb 20, 2019

Merged into #14

@solsson solsson closed this Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atamon @solsson