-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for multiple onupdate hook URLs #14
Conversation
…st-sequence (which last commit broke)
Let's see what happens when we re-enable the nodejs test.
Error: build-contract only wants to push to "localhost..."! Not a valid image name: yolean/kafka-keyvalue:dev
but I failed to figure out how to test our metrics analysis
are shown after the test result, indicating that there's something we don't wait for
We could have mounted a second volume, but this felt like a better quick fix
were still unavailable after promises that included retries so let's try the global setup feature insted as it blocks the test run.
Make all tests wait for services to come online
Getting timeouts when running build-contract or compose:
Maybe the internal name resolution doesn't work when the nodejs test isn't in `depends_on´ but if I add it there we'd get a circular dependency. We'd have to use standalone service that logs onupdate requests, with http based access for assertions. |
simple threads situation + loops etc confined to one class + TDD-friendly
but this time in a more elaborate way
Rewrites onupdate handling to process responses
we've figured out how the json layout can be used with bunyan, i.e. machine friendly logs can be piped to something that formats them nicely ideally the same way we do with node.js services. This layout tries to align message start vertically. Also avoids location information lookup. Kafka Streams thread names are really long. Instead of placing them last we could truncate them and not print full logger names. I'd say this closes #4.
@atamon I've pushed |
do reach the container's mockserver, which might hint that the issue with onupdate-flow spec is indeed a code issue not caused by the docker-compose setup.
build-contract passes now (though sometimes not when running dockerized as in |
Note however that build-contract doesn't really verify this at the moment. You have to manually check logs for
onupdate-logging
.The good news is that build-contract does pass, sometimes, now. See #3.
Once the nodejs based test is re-enabled we'll support validation of that url at least. See #5.