FED-1728 Migrate to null safety #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't really be made null safe, and we always intended on removing it in the next major.
Simulated synthetic events will be missing some properties if they're not included in eventData, meaning the non-nullable typings on them are incorrect. As opposed to making everything nullable to account for that, we'll treat those simulated events the same way Mockito treats mock objects, and just require that any properties being accessed get stubbed in using the eventData argument.
versioning it
useRef without an argument is more common than with one, and this
approach improves that experience by:
1. not requiring consumers explicitly provide `null` and provide
a nullable type argument
2. not involving a new, versioned API that must be migrated to
Importantly, this fixes some callback ref typing issues after fixing unnecessary_lambdas lints
greglittlefield-wf
force-pushed
the
null-safety-manual-2
branch
from
2d3e1e3
to
dbcf43a
Compare
greglittlefield-wf
force-pushed
the
null-safety-manual-2
branch
from
e4f4faf
to
7ab1084
Compare
test/nullable_callback_detection/nullable_callback_detection_sound_test.dart
Outdated
Show resolved
Hide resolved
| expect(array is List, isTrue); | ||
| array as List; |
There was a problem hiding this comment.
Whoa - is this new? Cast once and be done for the remaining scope?
There was a problem hiding this comment.
Yup! There's a bunch of tiny little type promotion improvements like this added alongside null safety; it's so nice!
componentWillUpdateWithContext/shouldComponentUpdateWithContext
|
+10 |
|
@Workiva/release-management-p |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This package needs to be upgraded to null safety in order for it to be used in other null-safe packages, and is a prerequisite for being consumed in Dart 3.
This PR contains the bulk of the changes that will make up the react-dart 7.0.0 major release.
A separate PR will be made into the v7_wip branch to perform other planned deprecated API removals. We can do a more complete audit of public API changes either at that point, or in the PR to merge the
v7_wipbranch.Changes
nullkey handling in JsBackedMap, required due to null-safe typing of getProperty/setProperty when implicit-casts are disabled, add testsasserts that callback ref args aren’t non-nullable, add testsReactComponentFactoryProxy.callreturn type fromdynamictoReactElementdynamictoReactDomComponentFactoryProxyforwardRef,memo,main.fromJsTesting