FED-1713 Null safety: perform migration, set up base for 5.0.0 integration branch #856

greglittlefield-wf · 2023-11-14T18:44:11Z

Motivation

We need to migrate over_react to null safety.

This migration has been spiked and developed intermittently within the null-safety branch, and it's time to get that work cleaned up and merged into an integration branch, to use as a base to complete the remaining null safety work.

Changes

Initial implementations of updating codegen to support null-safe libraries:
- Generating null-safe code, conditionally based on source library (to be completed in FED-1720)
- Ability to specify non-nullable late props (to be completed in FED-1717)
Migrate package to null safety
- Migrate most example/test components to null safety with nullable props
- Begin migration of utility components (to be completed and fully reviewed in FED-1889 Null Safety: Audit public utility components #855)
- Introduce null-safe mockito setup
Miscellaneous notable changes
- Add WIP changelog entry
- Clean up noisy test output by declaring test tags in dart_test.yaml and suppressing some printed output
- Updated getPropKey implementation to work with non-nullable props since they throw when not specified
Breaking changes
- Made components with handwritten props classes into a uiJsComponents with generated props classes
  - Fragment
  - StrictMode
  - ReduxProvider (also added ReduxProviderPropsMixin)
- PropsMeta/StateMeta constructor arguments fields and keys are now required
Analyzer plugin partial implementations
- MissingRequiredPropDiagnostic support for late props spikes (to be completed in FED-1886)
- Sound null safety in tests, re-enable previously-unsound diagnostics (to be completed in FED-1763)

Review notes:

This is a pretty massive diff. I'd recommend reviewing it in the chunks listed below.

For review feedback that requires more extensive investigation or changes, let's lean toward cutting tickets and adding FIXMEs so that we can get these changes merged sooner.

If there are clean diffs or anything else I can set up to make the reviewing process more manageable, please let me know!

Recommended chunks (in whichever order you prefer):

Builder, builder tests
- lib/src/builder/
- test/vm_tests/builder/
- test_fixtures/
~~Utility components~~ Review instead in FED-1889 Null Safety: Audit public utility components #855
- lib/src/component/_deprecated/
- lib/src/component/abstract_transition*
- lib/src/component/error_boundary*
- lib/src/component/resize_sensor*
- lib/src/component/with_transition.dart
- lib/src/util/safe_render_manager/
Flux
- lib/src/component_declaration/flux_component
OverReact Redux
- lib/src/over_react_redux
Component core and utilities
- lib/src/component/ (minus utility components)
- lib/src/component_declaration/ (minus Flux)
- lib/src/util/
Analyzer plugin
- tools/analyzer_plugin/
Examples
- example/
- web/

QA Checklist

Tests were updated and provide good coverage of the changeset and other affected code
Manual testing was performed if needed
- Steps from PR author:
  - CI passes (except analyzer plugin; those will be fixed in follow-up PRs)
- Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

A Frontend Frameworks Design member has reviewed these changes
There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
For release PRs - Version metadata in Rosie comment is correct

+ Now that there are tagged releases that work with 2.12 and analyzer 0.40.x

…lyzer-range

…hints but not applying the migration Also excludes: - lib/src/component - lib/src/over_react_redux/devtools/ - lib/src/over_react_redux/over_react_flux.dart

…yzer)

…flux/over_react_test

…x unused local vars

…llability

aaronlademann-wf

lib/src/over_react_redux/over_react_redux.dart

tools/analyzer_plugin/lib/src/diagnostic/missing_required_prop.dart

tools/analyzer_plugin/test/integration/diagnostics/exhaustive_deps_test.dart

tools/analyzer_plugin/test/unit/util/boilerplate_utils_test.dart

web/flux_to_redux/simple/examples/redux_implementation/components/big_block.dart

web/over_react_redux/examples/dev_tools/components/counter.dart

web/over_react_redux/examples/multiple_stores/components/counter.dart

web/over_react_redux/examples/simple/components/counter.dart

web/over_react_redux/examples/simple/store.dart

aaronlademann-wf

+1

greglittlefield-wf · 2023-11-28T18:47:29Z

@aaronlademann-wf left a comment

+1

aaronlademann-wf and others added 30 commits February 4, 2021 16:01

Widen analyzer dependency range to fix dev channel builds

3b25e84

Move git diff check to its own step

155d73e

Try adding comments to speed up dev build?

e8305c4

Remove build_web_compilers/build_modules overrides

800a9fc

+ Now that there are tagged releases that work with 2.12 and analyzer 0.40.x

Copy dart version comment in generated parts

8f3a081

Let the consumer know we don’t support this ish yet

fb6d7ce

Merge branch 'master' of github.com:Workiva/over_react into widen-ana…

5b31e99

…lyzer-range

Merge branch 'widen-analyzer-range' into null-unsafe-compat-builder

570b422

Prep for null-safety

ad10b8b

Generate files

15cb823

Add some hints

e6aece8

Clean up some code to be easier to make null-safe

c317210

Use null safety tool to migrate most non-builder code in lib, adding …

ceaebc9

…hints but not applying the migration Also excludes: - lib/src/component - lib/src/over_react_redux/devtools/ - lib/src/over_react_redux/over_react_flux.dart

More migration hints in core lib/src/component files

8057181

Convert builder to be null-safe (minus using null safe deps like anal…

2b748f4

…yzer)

Fix hints

8d905e1

Upgrade to latest analyzer

09be6c8

Remove BuiltReduxUiComponent and related built_redux APIs

78afd8b

Fix unnecessary ReactElement cast lints

64f2a42

Don't reference removed forwardRef

1e7b574

Fix misc lints

3f5846d

Remove dart2_constant dependency

3114e3b

Point to null safety transformer utils branch

f830756

Upgrade all dependencies to null safe releases except for w_common/w_…

0ddfc25

…flux/over_react_test

Fix analysis errors after upgrading dependencies

f2f827a

Apply migration (Dart 2.13.3)

1687b64

Fix analysis errors in builder after running migration

909a57f

Fix warnings in builder after running migration

ad08ea2

Fix lints in builder after running migration

2da1db8

Remove conflicting extensions declared in package:collection

191cbb5

greglittlefield-wf added 20 commits November 17, 2023 15:10

Clean up more LHS types

d824d5e

Remove deprecated displayName arguments

03cbec8

Clean up FIXME comments

a1ce8a5

Address fixme in test

b123072

Ensure null node doesn't cause false positives with isNot assertions

72b7783

Clean up typings

afb5267

Remove test for removed displayName arg

1ee7435

Clean up nullabilities in resize sensor tests

128567f

Make test variables non-nullable

1b8eea5

Use a fresh ref each time

c3e6ee4

Test improvements: avoid false positives, clean up connectOptions, fi…

9c2b4de

…x unused local vars

Update FIXME comment

c533529

Revert unnecessary action arguments

5b56c14

Clean up unnecessary types added by migrator

8ded99d

Clean up BoilerplateMembersHelper nullability and usage in tests

5e82f0c

Clean up test shared variables and getBoilerplateMembersFromString nu…

46314cc

…llability

Clean up more shared variables and null-checks

92f7e5a

Clean up nullabilities in connect_test

e91e8e9

Clean up some more nullable shared test variables

468b948

Fix useSelector nullability, beef up test expectation

8a37dcb

greglittlefield-wf force-pushed the null-safety branch from 1cd4cd1 to 8a37dcb Compare November 20, 2023 22:56

greglittlefield-wf added 3 commits November 20, 2023 16:04

Add comment amount componentFactory nullability, add doc comment

2034128

Improve nullable callback prop calls in tests

02eb3f3

Make some test component props non-nullable

c978df3

aaronlademann-wf reviewed Nov 27, 2023

View reviewed changes

greglittlefield-wf added 2 commits November 28, 2023 10:52

Clean up test ! operators

94d4d6b

Clean up fixmes and comments in required prop diagnostic

a15bd8f

aaronlademann-wf approved these changes Nov 28, 2023

View reviewed changes

greglittlefield-wf merged commit 8eeb5cd into v5_wip Dec 1, 2023
7 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FED-1713 Null safety: perform migration, set up base for 5.0.0 integration branch #856

FED-1713 Null safety: perform migration, set up base for 5.0.0 integration branch #856

greglittlefield-wf commented Nov 14, 2023 •

edited

Loading

aaronlademann-wf left a comment

aaronlademann-wf left a comment

greglittlefield-wf commented Nov 28, 2023

@aaronlademann-wf left a comment

FED-1713 Null safety: perform migration, set up base for 5.0.0 integration branch #856

FED-1713 Null safety: perform migration, set up base for 5.0.0 integration branch #856

Conversation

greglittlefield-wf commented Nov 14, 2023 • edited Loading

Motivation

Changes

Review notes:

QA Checklist

Merge Checklist

aaronlademann-wf left a comment

Choose a reason for hiding this comment

aaronlademann-wf left a comment

Choose a reason for hiding this comment

greglittlefield-wf commented Nov 28, 2023

@aaronlademann-wf left a comment

greglittlefield-wf commented Nov 14, 2023 •

edited

Loading