-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim down the upgrade testing workflow. #7966
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Mukesh Panchal <[email protected]>
I've made one adjustment to the strategy as described above. I've separated out the oldest version still receiving security updates and expanded the matrix to ensure it's tested against the same range of releases as the last 2 releases. I think that it makes sense to run the oldest version against the full set of combinations. With this addition, it brings the reduction to ~57%, a total of 416 jobs. |
As it stands today, the upgrade testing workflow is currently at ~978 jobs created. While it's great to test all possible combinations, GitHub's UI cannot keep up with tracking that number of jobs, and that is 2x the total number of allowed jobs for the organization (which slows everything down even more).
This PR trims down the number of combinations included in the testing matrices to be a bit more thoughtful following the following methodology:
Some additional notes about the chosen MySQL versions:
The contents of this PR description are included as inline documentation in the workflow to help guide contributors when updating this workflow in the future.
The changes in this workflow decrease the total number of jobs from 978 to 360 (a 63% reduction) and results in the entire job completing in less than 10 minutes (it currently takes anywhere from 20-40 minutes for the workflow to reflect the outcome of all spawned jobs).
Trac ticket: https://core.trac.wordpress.org/ticket/62221
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.