Media Text Block: Image size option for featured image #67464
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +107 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
…nt/resolution-option-for-featured-image-media-text-block
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in d32454f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12118987166
|
There was a problem hiding this comment.
Thanks for putting this together @akasunil 👍
It looks like this PR makes an unintended change to the way image urls fallback i.e. they no longer prefer the large size rather than full if mediaSizeSlug isn't set.
Can you also update the PR test instructions to cover this aspect of the PR's changes?
Comment on lines
105
to
108
| // Try the "large" size URL, falling back to the "full" size URL below. | ||
| src = | ||
| media.sizes?.large?.url || | ||
| // eslint-disable-next-line camelcase | ||
| media.media_details?.sizes?.large?.source_url; | ||
| media.sizes?.[ mediaSizeSlug ]?.url || | ||
| media?.media_details?.sizes?.[ mediaSizeSlug ]?.source_url; |
There was a problem hiding this comment.
This code no longer matches the inline comment above.
I assume the intent of this change is so that any specified mediaSizeSlug is used however now it won't prefer large instead of full as the unchanged comment suggests.
…nt/resolution-option-for-featured-image-media-text-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolution size support for the featured image is missing in the media text block.
Why?
When the featured image is used in media text block, the
ResolutionToolis not currently available.How?
This PR implement
ResolutionToolsupport for featured image. Along with that, cleaning up some issues/bugs that was already present trunk and discovered while working on this PR.Following are the fixes,
Use Featured Imageon click of theResetoption in the toolbarUse Featured Imageoption on selection.Testing Instructions
Use Featured Imageoption from toolbar of Media-Text blockResolutiondropdown in Media-Text block controlslargetofullifmediaSizeSlugisn't available, as default resolution option isfull.Screenshots or screencast
Edit-Post-.Hello-world-.-.-gutenberg-.-WordPress.4.webm