-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured Image Block: Refactor setting panel #67456
base: trunk
Are you sure you want to change the base?
Featured Image Block: Refactor setting panel #67456
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +142 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
I discovered that the featured image block already has a Custom Resolution drop-down under dimension control. The questions i have now are,
|
I've added the The ideal outcome is that the placement of the resolution control would be consistent across all blocks. Where exactly the control makes the most sense, I'll defer to our design gurus. It might also pay to provide screenshots of the two current locations for comparison, or create a dedicated issue where it's final home can be discussed. |
How many of those were only just recent additions though that didn't take into account the precedent set by the Featured Image block? |
Resolution support in I added a resolution option under dimension control to the cover block, following the precedent set by the featured image block. However, after receiving feedback on the comment, I had to move it to the settings panel. |
Thanks for the digging @akasunil but the history detailed misses the biggest part of the question, the Featured Image block. I was hoping to understand whether the Featured Image had the resolution controls first before the Image block etc. To determine what the true precedent was. @richtabor, when you get a moment, could you confirm whether we should also be moving the Featured Image's resolution control to the settings panel? I suspect we will given recent directions but want to double check as more PRs are being spun up around this. |
What? & Why?
Featured image block missing image resolution setting reported in #65350,
While working on implementation of Resolution option in Featured image block, Its appeared that
ResolutionTools
component is composed ofToolsPanelItem
, it must be placed inside theToolsPanel
component. The current Settings panel does not use theToolsPanel
component, so the entire settings panel is refactored.Testing Instructions
Screenshots or screencast
Edit-Post-.Hello-world-.-.-gutenberg-.-WordPress.3.webm