Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON: Clarify status of fixed position opt-in in appearance tools #48660

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Theme JSON: Clarify status of fixed position opt-in in appearance tools #48660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
410c062
Theme JSON: Clarify status of fixed position opt-in in appearance tools
andrewserong Mar 1, 2023
5ed96a5
Fix typo
andrewserong Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/class-wp-theme-json-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ public static function get_element_class_name( $element ) {
* Options that settings.appearanceTools enables.
*
* @since 6.0.0
* @since 6.2.0 Added `position.fixed` and `position.sticky`.
* @since 6.2.0 Added `dimensions.minHeight` and `position.sticky`.
* @var array
*/
const APPEARANCE_TOOLS_OPT_INS = array(
Expand All @@ -555,7 +555,12 @@ public static function get_element_class_name( $element ) {
array( 'border', 'width' ),
array( 'color', 'link' ),
array( 'dimensions', 'minHeight' ),
// BEGIN EXPERIMENTAL.
// Allow `position.fixed` to be opted-in by default.
// Sticky position support was backported to WordPress 6.2 in https://core.trac.wordpress.org/ticket/57618.
// While `fixed` was included as a valid setting, exposing it by default it still experimental.
andrewserong marked this conversation as resolved.
Show resolved Hide resolved
array( 'position', 'fixed' ),
// END EXPERIMENTAL.
array( 'position', 'sticky' ),
array( 'spacing', 'blockGap' ),
array( 'spacing', 'margin' ),
Expand Down