Theme JSON: Clarify status of fixed position opt-in in appearance tools #48660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48635
Add a comment to the Theme JSON class clarifying the current status of the
position.fixed
opt-in within appearance tools.Why?
As raised in #48635, without a comment, it isn't clear why there's a discrepancy between the core code and the Gutenberg code for this particular opt-in.
As discussed in #48635 (comment) and WordPress/wordpress-develop#3973 (comment), Gutenberg should be slightly more permissive than core here, so that it's easier to test subsequent explorations in adding
fixed
to the Group block, but this wasn't desired in core. In core,fixed
is a valid setting, but it needs to be opted-in intentionally so that it isn't accidentally exposed anywhere.How?
Add a comment to the Theme JSON class explaining the current status of the
position.fixed
opt-in. This uses the same// BEGIN EXPERIMENTAL
and// END EXPERIMENTAL
comments I've seen used elsewhere.Testing Instructions