Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Add "log in" link to local nav #2885

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Navigation: Add "log in" link to local nav #2885

merged 1 commit into from
Sep 18, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Sep 13, 2024

This updates Learn to include the "Log in" link in the local navigation across the site. The link only appears when you're logged out, once logged in, you can manage your account/login status in the admin bar. Once logged in, the "Log in" link disappears.

Once merged, the "Logged out admin bar" plugin should be disabled.

See WordPress/wporg-mu-plugins#647

How to test the changes in this Pull Request:

  1. Be logged out
  2. There should be a "log in" link
  3. Clicking it and signing in should redirect you back to the page you were just on
  4. The "log in" link should not appear
  5. You should see the admin bar

@ryelle ryelle added the [Component] Learn Theme Website development issues related to the Learn theme. label Sep 13, 2024
@ryelle ryelle self-assigned this Sep 13, 2024
@ryelle ryelle requested a review from renintw September 13, 2024 21:17
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@renintw renintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@renintw renintw merged commit 4031ca9 into trunk Sep 18, 2024
1 check passed
@renintw renintw deleted the add/log-in-link branch September 18, 2024 19:30
@renintw
Copy link
Contributor

renintw commented Sep 18, 2024

Shipped to production and Logged out admin bar was deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants