-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login/Register links, move to secondary navigation, remove adminbar #647
Comments
Done. It's there because it's primarily for logged in users, as that's how you manage your pledge - but if you don't know how to login, probably not actively contributing. |
Ah good note. To clarify, if you are logged in it's okay to show the adminbar across all sections. And in fact ideally we show it across all sections if you're logged in, so you don't get an inverse jump in that case of the adminbar disappearing. |
Is showing menu items like "my favorites" for not logged-in visitors desirable? |
I'd think so, yes, it makes clear a benefit you get from logging in. Besides, clicking Favorites if logged in, would take you to a screen prompting you to do that. |
I wonder if we could explore something similar to the Amazon experience. The login/register is combined with more info revealed in a dropdown, and it's placed in the primary header. This is tricky with the Navigation block, but might be worth exploring. |
I've updated this issue based on a fresh audit of the WordPress.org site after the recent string of style refreshes, then collaborated with @fcoveram to leverage the new secondary navigation bar for a simple and claer sign-in link that's contextual to the pages that need it. It's a big win that improves an increasingly frustrating aspect of the new experience, so I added a high priority to it. I also opened #646 to make the logo bigger, which pairs well with this change now that we're in the same space, code-wise! Penny for your thoughts? |
Good point. "Log in" can work equally well. The motivation for "Sign in" was to simply emphasize the link a bit more. |
For the Photo Directory & Make sites, it looks like your screenshots are not using the current site, but the redesign mockups. Should those…
These should be fine to update, no issues. It will require updating each theme, and disabling the Admin Bar plugin on each site.
These are lower priority or have other concerns
We have some mu-plugins code which currently handles hiding it unless you have permissions, but that can easily be updated. |
Doing it on themes, plugins, patterns, learn and forums would be a big step forward. We migth be able to wait for refreshes of Make and Photos, to ask, how hard would it be to add the new secondary navigation bar to those? A rough sketch could look like this: Though I recognize those secondary bars would need to disappear when you're logged in. A hacky alternative (rough sketch) could be this: Would either of those be feasible?
The motivation is to remove the layout shift, so it'd be nice to show it across the whole site once logged in. That should also at least give you quick access to logging out, or editing your profile, even if you're on a page you don't have other permissions for. Thank you for looking! |
The second option would be more likely than adding the local nav without any other redesign updates, especially for Make. But a nav banner might be possible on the Photo Directory, it just wouldn't do the scrolling behavior that the others do.
Yes, I was saying we can do that. |
This shows the admin bar on all sites on WordPress.org once a user is logged in, regardless of permissions on the current site. See #647
* Navigation: Add "Sign in" link to local nav See WordPress/wporg-mu-plugins#647 * Pass current page for post-login redirection * Update text to "Log in" * Fix duplicate site path in redirect
See WordPress/wporg-mu-plugins#647, closes #368 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14045 74240141-8908-4e6f-9713-ba540dce6ec7
See WordPress/wporg-mu-plugins#647 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14077 74240141-8908-4e6f-9713-ba540dce6ec7
See WordPress/wporg-mu-plugins#647 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14079 74240141-8908-4e6f-9713-ba540dce6ec7
Local nav includes log in link when logged out. See #1 See WordPress/wporg-mu-plugins#647
Now that the majority of sections across WordPress.org are updated, with a consistent header and secondary navigation bar, the sections of the site that—when logged out—show the WordPress adminbar, stand out. Those sections feature the adminbar only to offer login and register links, features which are not going to be relevant to the majority of visitors. The adminbar appearing causes both a layout shift, and gives undue prominence to links that are only situationally relevant to a minority of users:
Here's a recent audit of sections that feature the adminbar, showing a ❌ next to the sections that still include it:
From this audit, we can extract the following sections still showing the adminbar, purely to support login/register links:
For those pages, there appears to be plenty of room to simply add a "Sign-in" link to the secondary navigation toolbar, like so:
Doing so would both avoid the layout shift of the adminbar appearing or disappearing as you navigate across the site, and it would also make the sign in link secondary to the primary navigation, thus implying its context implicitly: I can sign in here to submit a theme.
When you click "Sign in" you see this page:
On that page, if you click "Create an account" you see this page:
Here's a full flow of the suggested changes:
Note, this flow includes the mockup for a refreshed login page (#241). That's a separate effort.
Figma.
When you are successfully logged in, show the adminbar across the whole site. Shown here, logged out, and in, for the Forums section:
Summary:
Issue updated Aug 21.
Previous version of this issue ↓
Doing a quick review of navigating across all sections of WordPress.org this morning, and noticing a jump in the top navigation for every page that shows the adminbar. It seems that in every case where the adminbar shows, it exists to surface the login and register links. Here are pages that show the adminbar for this reason.
News:
Themes:
Plugins:
Patterns:
Learn:
Forums:
Make (both landing and all P2s):
Photos:
FFTF:
Also for reference, when you click "Log In" you see this page:
When you click "Register" you see this page:
In all these cases, those login/register links exist in context of those pages either being editable by contributors, or places where people can submit themes patterns, or otherwise. Those are all page-contextual actions, however, which suggest hierarchically those links should exist in context of the page, rather than in context of the site as they do when they are the first thing on the page.
Outside of fixing the hierarchy, addressing the jump is especially important on mobile, where those buttons get extra prominence and height:
Suggestions
Mockup showing a single unified Log in/Register link:
This single link leans into WordPress/wporg-main-2022#241, which puts a "Register" link right on the login page that'll take you there:
The text was updated successfully, but these errors were encountered: