Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other build variants #40

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add other build variants #40

merged 1 commit into from
Nov 16, 2023

Conversation

Blackhex
Copy link
Member

@Blackhex Blackhex commented Nov 7, 2023 •
edited
Loading

Adds x86_64-w64-mingw32 and ucrt builds.

Depends on #39 that needs to be merged first.

Closes #36, #22

@Blackhex Blackhex requested a review from ZacWalk November 7, 2023 22:11
@Blackhex Blackhex mentioned this pull request Nov 7, 2023
Closed
@Blackhex Blackhex force-pushed the split-jobs branch 5 times, most recently from 38f82dd to 2d2bedc Compare November 8, 2023 11:30
@Blackhex Blackhex force-pushed the build-variants branch 2 times, most recently from 3065789 to 8f58848 Compare November 8, 2023 13:41
This was referenced Nov 13, 2023
Closed
Closed
ZacWalk
ZacWalk approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@ZacWalk ZacWalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is isolated from the manual build script.

@Blackhex Blackhex changed the base branch from split-jobs to main November 16, 2023 08:41
@Blackhex Blackhex merged commit 476664e into main Nov 16, 2023
4 checks passed
@Blackhex Blackhex deleted the build-variants branch November 16, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eukarpov eukarpov eukarpov approved these changes

@ZacWalk ZacWalk ZacWalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add building of toolchains targetting windows-x64 and linux-aarch64
3 participants
@Blackhex @ZacWalk @eukarpov