Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmable user invitations #9566

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Confirmable user invitations #9566

merged 1 commit into from
Aug 7, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Jul 14, 2023

Proposed changes

  • Make invitations standalone model
  • Do not start social auth flow when sending an invitation
  • List user invitations to the user profile
  • Merge all e-mail invitations upon registering on a site

Closing #9261 and #9131

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #9566 (02bb1da) into main (0ab1430) will decrease coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 78.32%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9566      +/-   ##
==========================================
- Coverage   91.06%   91.00%   -0.06%     
==========================================
  Files         760      764       +4     
  Lines       56161    56271     +110     
  Branches     8732     8747      +15     
==========================================
+ Hits        51141    51208      +67     
- Misses       3492     3527      +35     
- Partials     1528     1536       +8     
Files Changed Coverage Δ
weblate/accounts/models.py 88.61% <ø> (ø)
weblate/auth/tasks.py 0.00% <0.00%> (ø)
weblate/trans/forms.py 87.79% <ø> (+0.20%) ⬆️
weblate/urls.py 81.70% <ø> (ø)
weblate/trans/models/change.py 80.28% <16.66%> (-0.64%) ⬇️
weblate/auth/views.py 67.15% <45.09%> (-13.75%) ⬇️
weblate/accounts/pipeline.py 81.78% <78.57%> (-0.76%) ⬇️
weblate/utils/forms.py 91.83% <80.00%> (-4.06%) ⬇️
weblate/auth/models.py 92.24% <80.76%> (-0.67%) ⬇️
weblate/accounts/views.py 83.76% <90.47%> (-0.12%) ⬇️
... and 10 more

... and 2 files with indirect coverage changes

@nijel nijel force-pushed the invitations branch 2 times, most recently from 44288a0 to 8636998 Compare July 27, 2023 09:50
@nijel nijel force-pushed the invitations branch 4 times, most recently from 153e2cd to 3bb2bd5 Compare July 31, 2023 13:10
@nijel nijel marked this pull request as ready for review July 31, 2023 13:11
@nijel nijel requested a review from orangesunny as a code owner July 31, 2023 13:11
@nijel nijel changed the title Add user invitations Confirmable user invitations Jul 31, 2023
@nijel nijel force-pushed the invitations branch 8 times, most recently from bfdeeff to 6fed5d8 Compare August 4, 2023 15:22
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
@nijel nijel merged commit 7a2c3db into WeblateOrg:main Aug 7, 2023
21 of 22 checks passed
@nijel nijel deleted the invitations branch August 7, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant