Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invitations without email login #9261

Closed
Bubu opened this issue May 17, 2023 · 2 comments · Fixed by #9566
Closed

Invitations without email login #9261

Bubu opened this issue May 17, 2023 · 2 comments · Fixed by #9566
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
5.0

Comments

@Bubu
Copy link
Contributor

Bubu commented May 17, 2023

Describe the problem

Our weblate installation at https://translate.codeberg.org/ has all user accounts backed by the gitea installation at codeberg.org.

AUTHENTICATION_BACKENDS = ("social_core.backends.gitea.GiteaOAuth2", "weblate.accounts.auth.WeblateUserBackend",)

This makes the invite functionality not work at all and confusing to users and their invited contributors that try to use them.

Describe the solution you'd like

I don't really see a way to make invites work if the user account that needs to be created is on a seperate platform, so I'd instead like to just disable this functionality in the UI completely.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

Report from a user at codeberg: https://codeberg.org/Codeberg/Community/issues/1027
@nijel nijel added bug Something is broken. enhancement Adding or requesting a new feature. and removed bug Something is broken. labels May 18, 2023
@nijel nijel mentioned this issue May 18, 2023
Closed
@nijel
Copy link
Member

nijel commented May 18, 2023

Actually, it makes sense to have invitations even without e-mail authentication:

  • To add people to projects
  • To invite people to start using Weblate

The invitations can still work:

  • User receives e-mail
  • Signs in using a third-party platform
  • The created account is linked with the invitation

This really needs #9131 as well.

@Bubu Bubu changed the title Allow deactivating email invitations Invitations without email login / Allow deactivating email invitations May 18, 2023
@nijel nijel added this to the 5.0 milestone Jul 14, 2023
@nijel nijel self-assigned this Jul 14, 2023
@nijel nijel changed the title Invitations without email login / Allow deactivating email invitations Invitations without email login Jul 14, 2023
nijel added a commit to nijel/weblate that referenced this issue Jul 14, 2023
@nijel
auth: Add model to store user invitations
aae1ed2 
See WeblateOrg#9261 and WeblateOrg#9131
@nijel nijel mentioned this issue Jul 14, 2023
Merged
9 tasks
@nijel nijel linked a pull request Jul 14, 2023 that will close this issue
Confirmable user invitations #9566
Merged
9 tasks
nijel added a commit to nijel/weblate that referenced this issue Jul 21, 2023
@nijel
auth: Use standalone models for invitations
44288a0 
- remove invite hacks from the social pipeline
- TODO: rewritten invitation to send invites directly
- invitations now work regardless registration open
- TODO: project admins can only invite outside users with registration
  open
- TODO: new mail templates for invitations
- TODO: user profile view of pending invitations
- TODO: user has to accept the invitation to become team member

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 27, 2023
@nijel
auth: Use standalone models for invitations
8636998 
- remove invite hacks from the social pipeline
- TODO: rewritten invitation to send invites directly
- invitations now work regardless registration open
- TODO: project admins can only invite outside users with registration
  open
- improved mail templates for invitations
- TODO: user profile view of pending invitations
- TODO: user has to accept the invitation to become team member

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 31, 2023
@nijel
auth: Use standalone models for invitations
f2812f6 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 31, 2023
@nijel
auth: Use standalone models for invitations
a97aced 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- TODO: add admin view of pending invitations
- TODO: add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 31, 2023
@nijel
auth: Use standalone models for invitations
153e2cd 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- TODO: add admin view of pending invitations
- TODO: add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 31, 2023
@nijel
auth: Use standalone models for invitations
3bb2bd5 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Jul 31, 2023
@nijel
auth: Use standalone models for invitations
d508207 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 1, 2023
@nijel
auth: Use standalone models for invitations
5b80b84 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 1, 2023
@nijel
auth: Use standalone models for invitations
1554d46 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 1, 2023
@nijel
auth: Use standalone models for invitations
1a29826 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 2, 2023
@nijel
auth: Use standalone models for invitations
eccf12f 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 2, 2023
@nijel
auth: Use standalone models for invitations
f69ee10 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 4, 2023
@nijel
auth: Use standalone models for invitations
bfdeeff 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 4, 2023
@nijel
auth: Use standalone models for invitations
6fed5d8 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit to nijel/weblate that referenced this issue Aug 5, 2023
@nijel
auth: Use standalone models for invitations
02bb1da 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes WeblateOrg#9261
Fixes WeblateOrg#9131
Fixes WeblateOrg#7412
nijel added a commit that referenced this issue Aug 7, 2023
@nijel
auth: Use standalone models for invitations
7a2c3db 
- remove invite hacks from the social pipeline
- rewritten invitation to send invites directly
- invitations now work regardless registration open
- project admins can only invite outside users with registration open
- improved mail templates for invitations
- user profile view of pending invitations
- user has to accept the invitation to become a team member
- add admin view of pending invitations
- add copy button to copy full invitation URL in admin

Fixes #9261
Fixes #9131
Fixes #7412
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Confirmable user invitations nijel/weblate
2 participants
@Bubu @nijel