changes: consolidate action names #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
force-pushed
the
change-event
branch
2 times, most recently
from
46808bb
to
0b56a27
Compare
2 tasks
|
I prefer these changes:
I am not sure about the last one. Please note there is a typo in Trasnlation |
|
@urbalazs Thanks for the feedback, I've applied your suggestions. |
Geeyun-JY3
reviewed
Oct 11, 2023
weblate/trans/models/change.py
Outdated
| # Using pgettext to differentiate from the plural | ||
| # Translators: Name of event in the history | ||
| ( | ||
| ACTION_NEW_STRING, | ||
| pgettext_lazy("Name of event in the history", "New string to translate"), | ||
| pgettext_lazy("Name of event in the history", "String added"), |
There was a problem hiding this comment.
There are two String added after changing New string added to String added. It is needed to distinguish these two events.
There was a problem hiding this comment.
Good point, I think it's time to drop this event. Tracked separately at #10153
nijel
force-pushed
the
change-event
branch
2 times, most recently
from
72c106a
to
90d0bf8
Compare
It was really doing just aggregation which can now be handled in the notification subsystem. Notification now triggers on ACTION_NEW_UNIT and is doing digests for users who had instant notification up to now. Fixes WeblateOrg#10153
Consistently use noun + verb past. Fixes WeblateOrg#9824
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10135 +/- ##
==========================================
+ Coverage 90.86% 91.04% +0.18%
==========================================
Files 537 529 -8
Lines 55661 55507 -154
Branches 8832 8798 -34
==========================================
- Hits 50576 50536 -40
+ Misses 3536 3417 -119
- Partials 1549 1554 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Consistently use noun + verb past.
Fixes #9824
Checklist
Other information