Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent history event names #9824

Closed
2 tasks done
urbalazs opened this issue Aug 29, 2023 · 4 comments · Fixed by #10135
Closed
2 tasks done

Inconsistent history event names #9824

urbalazs opened this issue Aug 29, 2023 · 4 comments · Fixed by #10135
Assignees
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Milestone

Comments

@urbalazs
Copy link
Contributor

urbalazs commented Aug 29, 2023

Describe the issue

The name of history events are inconsistent, see this section. Some examples:

  • Resource update: noun + verb
  • Translation completed: noun + verb past
  • New translation: no verb
  • Removed comment: verb past + noun

They should be consistent like "Something happened" (noun + verb past):

  • Resource updated
  • Translation completed
  • Translation added
  • Comment removed

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

Open this section

or

Open /changes/browse/PROJECT/COMPONENT/ to see all events in the GUI.

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added this to the 5.1 milestone Aug 29, 2023
@nijel nijel added enhancement Adding or requesting a new feature. ux Issues related to user experience. labels Aug 29, 2023
@nijel nijel self-assigned this Oct 10, 2023
nijel added a commit to nijel/weblate that referenced this issue Oct 10, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit to nijel/weblate that referenced this issue Oct 11, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit to nijel/weblate that referenced this issue Oct 11, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
@nijel
Copy link
Member

nijel commented Oct 11, 2023

#10135 tries to consolidate this, reviews welcome.

nijel added a commit to nijel/weblate that referenced this issue Oct 11, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
@Geeyun-JY3
Copy link
Collaborator

I have been confused by these inconsistent event names for a long time while translating.
Currently, some of the Simplified Chinese translations of these event names actually imply that it was someone who did these events, which is in the active voice. These event names shown below the user’s avatar in the UI also make the active voice look reasonable: this layout implies that someone (the avatar) did something (the event shown below).

If #10135 is implemented (changing all these event names to noun + verb past participle, that is passive voice), is it still necessary to imply that was someone who did these events in translations?

@nijel
Copy link
Member

nijel commented Oct 11, 2023

Typically there is someone who did the action. But there are also automated events (automatic translation) or actors outside Weblate (changes in the repository).

nijel added a commit to nijel/weblate that referenced this issue Oct 11, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit to nijel/weblate that referenced this issue Oct 11, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit to nijel/weblate that referenced this issue Oct 12, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit to nijel/weblate that referenced this issue Oct 12, 2023
Consistently use noun + verb past.

Fixes WeblateOrg#9824
nijel added a commit that referenced this issue Oct 12, 2023
Consistently use noun + verb past.

Fixes #9824
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants