Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark the PerformanceMetrics methods as overrides of IPlugin
[28/34] Building CXX object PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o FAILED: PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderPerformanceMetrics_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -g -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -O0 -g -MD -MT PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o -MF PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o.d -o PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o -c /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:667:30: error: 'Initialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual const string Initialize(PluginHost::IShell* service); ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:81:30: note: overridden virtual function is here virtual const string Initialize(PluginHost::IShell* shell) = 0; ^ In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:673:22: error: 'Deinitialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual void Deinitialize(PluginHost::IShell* service); ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:90:22: note: overridden virtual function is here virtual void Deinitialize(PluginHost::IShell* shell) = 0; ^ In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:677:24: error: 'Information' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual string Information() const; ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:97:24: note: overridden virtual function is here virtual string Information() const = 0; ^ 3 errors generated.
- Loading branch information