Skip to content

Commit

Permalink
Adding overrides and marking member variable as not used
Browse files Browse the repository at this point in the history
[18/34] Building CXX object OpenCDMi/CMakeFiles/ThunderOCDM.dir/CENCParser.cpp.o
FAILED: OpenCDMi/CMakeFiles/ThunderOCDM.dir/CENCParser.cpp.o 
/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderOCDM_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -O3 -DNDEBUG -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT OpenCDMi/CMakeFiles/ThunderOCDM.dir/CENCParser.cpp.o -MF OpenCDMi/CMakeFiles/ThunderOCDM.dir/CENCParser.cpp.o.d -o OpenCDMi/CMakeFiles/ThunderOCDM.dir/CENCParser.cpp.o -c /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/CENCParser.cpp
In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/CENCParser.cpp:20:
In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/CENCParser.h:25:
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/Protobuf.h:466:18: error: 'Type' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        WireType Type() const {
                 ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/Protobuf.h:40:26: note: overridden virtual function is here
        virtual WireType Type() const = 0;
                         ^
1 error generated.
[19/34] Building CXX object Monitor/CMakeFiles/ThunderMonitor.dir/Monitor.cpp.o
[20/34] Building CXX object OpenCDMi/CMakeFiles/ThunderOCDM.dir/OCDM.cpp.o
[21/34] Building CXX object OpenCDMi/CMakeFiles/ThunderOCDM.dir/OCDMJsonRpc.cpp.o
[22/34] Building CXX object OpenCDMi/CMakeFiles/ThunderOCDM.dir/FrameworkRPC.cpp.o
FAILED: OpenCDMi/CMakeFiles/ThunderOCDM.dir/FrameworkRPC.cpp.o 
/Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderOCDM_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -O3 -DNDEBUG -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT OpenCDMi/CMakeFiles/ThunderOCDM.dir/FrameworkRPC.cpp.o -MF OpenCDMi/CMakeFiles/ThunderOCDM.dir/FrameworkRPC.cpp.o.d -o OpenCDMi/CMakeFiles/ThunderOCDM.dir/FrameworkRPC.cpp.o -c /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp
In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:25:
In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/CENCParser.h:25:
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/Protobuf.h:466:18: error: 'Type' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        WireType Type() const {
                 ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/Protobuf.h:40:26: note: overridden virtual function is here
        virtual WireType Type() const = 0;
                         ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:953:35: error: 'GetSecureStopIds' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            Exchange::OCDM_RESULT GetSecureStopIds(
                                  ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IOCDM.h:229:25: note: overridden virtual function is here
    virtual OCDM_RESULT GetSecureStopIds(const string& keySystem,
                        ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:980:35: error: 'CommitSecureStop' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
            Exchange::OCDM_RESULT CommitSecureStop(
                                  ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IOCDM.h:240:25: note: overridden virtual function is here
    virtual OCDM_RESULT CommitSecureStop(const string& keySystem,
                        ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:1421:26: error: 'Reset' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual uint32_t Reset()
                         ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IContentDecryption.h:35:26: note: overridden virtual function is here
        virtual uint32_t Reset() = 0;
                         ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:1425:39: error: 'Systems' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual RPC::IStringIterator* Systems() const
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IContentDecryption.h:36:39: note: overridden virtual function is here
        virtual RPC::IStringIterator* Systems() const = 0;
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:1429:39: error: 'Designators' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual RPC::IStringIterator* Designators(const string& keySystem) const
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IContentDecryption.h:37:39: note: overridden virtual function is here
        virtual RPC::IStringIterator* Designators(const string& keySystem) const = 0;
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:1435:39: error: 'Sessions' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual RPC::IStringIterator* Sessions(const string& keySystem) const
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Release/install/usr/include/Thunder/interfaces/IContentDecryption.h:38:39: note: overridden virtual function is here
        virtual RPC::IStringIterator* Sessions(const string& keySystem) const = 0;
                                      ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:378:48: error: private field '_mediaKeysExt' is not used [-Werror,-Wunused-private-field]
                    CDMi::IMediaKeySessionExt* _mediaKeysExt;
                                               ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:379:30: error: private field '_sessionKey' is not used [-Werror,-Wunused-private-field]
                    uint8_t* _sessionKey;
                             ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:380:30: error: private field '_sessionKeyLength' is not used [-Werror,-Wunused-private-field]
                    uint32_t _sessionKeyLength;
                             ^
/Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/OpenCDMi/FrameworkRPC.cpp:751:34: error: private field '_refCount' is not used [-Werror,-Wunused-private-field]
                mutable uint32_t _refCount;
                                 ^
11 errors generated.
  • Loading branch information
VeithMetro authored Nov 13, 2024
1 parent 2098cdd commit b014622
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions OpenCDMi/FrameworkRPC.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,9 @@ namespace Plugin {

private:
CDMi::IMediaKeySession* _mediaKeys;
CDMi::IMediaKeySessionExt* _mediaKeysExt;
uint8_t* _sessionKey;
uint32_t _sessionKeyLength;
VARIABLE_IS_NOT_USED CDMi::IMediaKeySessionExt* _mediaKeysExt;
VARIABLE_IS_NOT_USED uint8_t* _sessionKey;
VARIABLE_IS_NOT_USED uint32_t _sessionKeyLength;
};

// IMediaKeys defines the MediaKeys interface.
Expand Down Expand Up @@ -748,7 +748,7 @@ POP_WARNING()
private:
AccessorOCDM& _parent;
mutable Core::CriticalSection _adminLock;
mutable uint32_t _refCount;
VARIABLE_IS_NOT_USED mutable uint32_t _refCount;
std::string _keySystem;
std::string _sessionId;
CDMi::IMediaKeySession* _mediaKeySession;
Expand Down Expand Up @@ -954,7 +954,7 @@ POP_WARNING()
const std::string& keySystem,
unsigned char Ids[],
uint16_t idsLength,
uint32_t& count)
uint32_t& count) override
{
CDMi::IMediaKeysExt* systemExt = dynamic_cast<CDMi::IMediaKeysExt*>(_parent.KeySystem(keySystem));
if (systemExt) {
Expand Down Expand Up @@ -982,7 +982,7 @@ POP_WARNING()
const unsigned char sessionID[],
uint16_t sessionIDLength,
const unsigned char serverResponse[],
uint16_t serverResponseLength)
uint16_t serverResponseLength) override
{
CDMi::IMediaKeysExt* systemExt = dynamic_cast<CDMi::IMediaKeysExt*>(_parent.KeySystem(keySystem));
if (systemExt) {
Expand Down Expand Up @@ -1418,21 +1418,21 @@ POP_WARNING()
}
}

virtual uint32_t Reset()
virtual uint32_t Reset() override
{
return (Core::ERROR_NONE);
}
virtual RPC::IStringIterator* Systems() const
virtual RPC::IStringIterator* Systems() const override
{
return (Core::ServiceType<RPC::StringIterator>::Create<RPC::IStringIterator>(_keySystems));
}
virtual RPC::IStringIterator* Designators(const string& keySystem) const
virtual RPC::IStringIterator* Designators(const string& keySystem) const override
{
std::list<string> designators;
LoadDesignators(keySystem, designators);
return (Core::ServiceType<RPC::StringIterator>::Create<RPC::IStringIterator>(designators));
}
virtual RPC::IStringIterator* Sessions(const string& keySystem) const
virtual RPC::IStringIterator* Sessions(const string& keySystem) const override
{
std::list<string> sessions;
LoadSessions(keySystem, sessions);
Expand Down

0 comments on commit b014622

Please sign in to comment.