Integrate with Permissions #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
good stuff... and you are right, the whole .requestMIDIAccess() section be replaced by hooking into our spec.
However, seems "software" as type got added at some point.
requestMIDIAccess(optional MIDIOptions options = {}); should be changed to:
requestMIDIAccess(optional MidiPermissionDescriptor options = {});
And MidiPermissionDescriptor should gain the software member (we can copy/pasta the definition that's already there for MidiOptions). I think MidiOptions can then be deleted form the spec.
|
(we can do the above in two passes...) |
Co-authored-by: Marcos Cáceres <[email protected]>
Yeah, let me file an issue to do that as a follow up. PTAL @cwilso! |
|
Thanks Mike! |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of w3c/permissions#263, this PR moves some of the Permissions stuff into WebMidi (so Permissions doesn't have to be a registry, but instead defines powerful features infrastructure).
It also fixes some bugs in the Permissions policy section.
cc @marcoscaceres