Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite requestMIDIAccess to hook into permissions #220

Open
miketaylr opened this issue Oct 20, 2021 · 10 comments
Open

Rewrite requestMIDIAccess to hook into permissions #220

miketaylr opened this issue Oct 20, 2021 · 10 comments
Labels
Agenda+ https://speced.github.io/spec-maintenance/about/ category: enhancement https://www.w3.org/policies/process/#class-3 Needs Discussion The issue needs more discussion before it can be fixed. Priority: Soon https://speced.github.io/spec-maintenance/about/
Milestone

Comments

@miketaylr
Copy link
Contributor

As a followup to #219 (review)

@cwilso
Copy link
Contributor

cwilso commented Oct 26, 2021

What remains on top of #294?

@miketaylr
Copy link
Contributor Author

Sorry for not writing a better description!

Essentially, https://webaudio.github.io/web-midi-api/#dom-navigator-requestmidiaccess needs to hook into the Permissions algorithms.

@marcoscaceres wrote some more explicit suggestions in #219 (review).

@miketaylr
Copy link
Contributor Author

I will attempt to not mess this up.

miketaylr added a commit to miketaylr/web-midi-api that referenced this issue Oct 27, 2021
miketaylr added a commit to miketaylr/web-midi-api that referenced this issue Oct 27, 2021
miketaylr added a commit to miketaylr/web-midi-api that referenced this issue Oct 27, 2021
miketaylr added a commit to miketaylr/web-midi-api that referenced this issue Oct 27, 2021
miketaylr added a commit to miketaylr/web-midi-api that referenced this issue Oct 27, 2021
@hoch
Copy link
Member

hoch commented Apr 6, 2023

Teleconference 4/6:
Remove "particularly if system exclusive access is requested." in the second paragraph of https://www.w3.org/TR/webmidi/#requestmidiaccess.

@hoch hoch self-assigned this Apr 6, 2023
@miketaylr
Copy link
Contributor Author

I will attempt to not mess this up.

(It looks like I never finished...)

@hoch
Copy link
Member

hoch commented Apr 6, 2023

No worries! We'll take it from here. :)

@miketaylr
Copy link
Contributor Author

Yay, thanks! I'll go ahead and close my WIP PR now.

@hoch hoch added the Needs Edits https://speced.github.io/spec-maintenance/about/ label Sep 11, 2023
@mjwilson-google mjwilson-google added the category: enhancement https://www.w3.org/policies/process/#class-3 label Sep 13, 2023
@mjwilson-google mjwilson-google added this to the CR milestone Sep 14, 2023
@mjwilson-google mjwilson-google added Agenda+ https://speced.github.io/spec-maintenance/about/ and removed Needs Edits https://speced.github.io/spec-maintenance/about/ labels Oct 15, 2023
@mjwilson-google
Copy link
Contributor

Audio WG 2023-10-18 conclusion:

@mjwilson-google mjwilson-google added Needs Edits https://speced.github.io/spec-maintenance/about/ and removed Agenda+ https://speced.github.io/spec-maintenance/about/ labels Oct 18, 2023
@mjwilson-google mjwilson-google added the Priority: Soon https://speced.github.io/spec-maintenance/about/ label Nov 27, 2024
@mjwilson-google mjwilson-google added Agenda+ https://speced.github.io/spec-maintenance/about/ Needs Discussion The issue needs more discussion before it can be fixed. and removed Needs Edits https://speced.github.io/spec-maintenance/about/ labels Dec 30, 2024
@mjwilson-google
Copy link
Contributor

I think changing the requestMIDIAccess API has compatibility risk. I will raise this again at the next working group meeting.

@mjwilson-google
Copy link
Contributor

Specifically, there are three options I see:

  • Add a new API that takes a MIDIPermissionDescriptor and remove the old API.
  • Add a new API and deprecate the old API (potentially keeping the deprecated API forever).
  • Don't add a new API and just continue to use the old API with the MIDIOptions dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ https://speced.github.io/spec-maintenance/about/ category: enhancement https://www.w3.org/policies/process/#class-3 Needs Discussion The issue needs more discussion before it can be fixed. Priority: Soon https://speced.github.io/spec-maintenance/about/
Projects
None yet
Development

No branches or pull requests

4 participants