Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPEC] Fix for selectedBuyerAndSellerReportingId #1317

Merged
merged 5 commits into from
Oct 29, 2024
Merged

[SPEC] Fix for selectedBuyerAndSellerReportingId #1317

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42e9f27
Add check for selected reporting id in generate bid output
HabibiYou Oct 29, 2024
e9e6586
fixed indents
HabibiYou Oct 29, 2024
ddd87ef
add null check
HabibiYou Oct 29, 2024
563e5a3
Add to estimated size
HabibiYou Oct 29, 2024
fe6ef34
add missing space
HabibiYou Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2165,7 +2165,7 @@ To <dfn>convert to an AuctionAd sequence</dfn> given a [=list=]-or-null |ads|:
1. [=map/Set=] |adIDL|["{{AuctionAd/renderURL}}"] to the [=URL serializer|serialization=] of
|ad|'s [=interest group ad/render url=].
1. If |ad|'s [=interest group ad/selectable buyer and seller reporting IDs=] is not null:
1.[=map/Set=] |adIDL|["{{AuctionAd/selectableBuyerAndSellerReportingIds}}"] to
1. [=map/Set=] |adIDL|["{{AuctionAd/selectableBuyerAndSellerReportingIds}}"] to
|ad|'s [=interest group ad/selectable buyer and seller reporting IDs=].
1. If |ad|'s [=interest group ad/buyer and seller reporting id=] is not null then
[=map/set=] |adIDL|["{{AuctionAd/buyerAndSellerReportingId}}"] to
Expand Down Expand Up @@ -5198,6 +5198,9 @@ To <dfn>convert GenerateBidOutput to generated bid</dfn> given a {{GenerateBidOu
1. Set |bid|'s [=generated bid/ad descriptor=] to |adDescriptor|.
1. Set |bid|'s [=generated bid/bid ad=] to |bidAd|.
1. If |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"] [=map/exists=]:
1. If |bidAd|'s [=interest group ad/selectable buyer and seller reporting IDs=] is null, or does not
[=list/contain=] |generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"],
return failure.
1. Set |bid|'s [=generated bid/selected buyer and seller reporting ID=] to
|generateBidOutput|["{{GenerateBidOutput/selectedBuyerAndSellerReportingId}}"].
1. If |generateBidOutput|["{{GenerateBidOutput/adComponents}}"] [=map/exists=]:
Expand Down Expand Up @@ -5893,6 +5896,9 @@ The <dfn for="interest group">estimated size</dfn> of an [=interest group=] |ig|
1. The [=string/length=] of |ad|'s [=interest group ad/buyer reporting ID=] if the field is not null.
1. The [=string/length=] of |ad|'s [=interest group ad/buyer and seller reporting ID=] if the
field is not null.
1. If |ad|'s [=interest group ad/selectable buyer and seller reporting IDs=] is not null,
[=list/for each=] |id| of it:
1. The [=string/length=] of |id|.
1. If |ad|'s [=interest group ad/allowed reporting origins=] is not null, [=list/for each=]
|origin| of it:
1. The [=string/length=] of the [=serialization of an origin|serialization=] of |origin|.
Expand Down
Loading