[SPEC] Fix for selectedBuyerAndSellerReportingId #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusshamilton
approved these changes
Oct 29, 2024
|
not directly related, but seems we also forgot to add the selectable IDs size to interest group's estimated size (step 18) (code). |
HabibiYou
changed the title
qingxinwu
approved these changes
Oct 29, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 29, 2024
SHA: a8ae8e3 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to ensure that the generated bid's
selectedBuyerAndSellerReportingId, is present within the bid ad'sselectableBuyerAndSellerReportingIds, otherwise will return a failure.Also adds the size of
selectableBuyerAndSellerReportingIdsto theestimated sizealgorithm.Preview | Diff