-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec "Referer" and "Origin" headers in reporting beacons. #164
Conversation
Is this a draft or is this ready for my review? |
It's back to draft after changes were made during the impl's code review. I'll re-request when it's ready for you to take a look. |
Any idea why the latest preview does not seem to be updated? In the preview "declarer origin" can be null but I don't think that matches the spec text, right? |
I'm not sure. It seems to be working again since I uploaded the latest patch, so you should be good to look at the preview/diff. |
Let's hold off on merging this until the latest discussion in the design doc is addressed. |
SHA: 1454a61 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR specs the following behavior:
reportEvent()
for destination URL events.reporting url declarer origin
) for destination enum and automatic beacon events.initiator ancestor root origin
) for automatic beacons triggered by component ad frames.See this document for notes/reasonings on why things were done the way they were.
There will need to be a separate effort in the Protected Audience spec to set some of the values that these changes are expecting to be set. More specifically:
reporting url declarer origin
variable will need to be set during the asynchronously finish reporting when it invokes finalize a reporting destination.Preview | Diff