Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp* #358

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp* #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c453b
[IMP] viin_brand_auth_totp*: Viindoo debranding for module auth_totp*
duyquyen96 Jun 15, 2023
3429328
[IMP] viin_brand_auth_totp_mail: fix test pylint
duyquyen96 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions viin_brand_auth_totp/views/user_perferences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,14 @@
</xpath>
</field>
</record>
<record id="view_totp_form" model="ir.ui.view">
<field name="name">user form: add totp status</field>
<field name="model">res.users</field>
<field name="inherit_id" ref="auth_totp.view_totp_form" />
<field name="arch" type="xml">
<xpath expr="//div/span/a" position="attributes">
<attribute name="href">https://viindoo.com/documentation/15.0/applications/getting-started/external-apps-integration/two-factor-authentication.html</attribute>
</xpath>
</field>
</record>
</odoo>
Empty file added viin_brand_auth_totp_mail/__init__.py
View file
Open in desktop
Empty file.
62 changes: 62 additions & 0 deletions viin_brand_auth_totp_mail/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
{
'name': "2FA Invite mail Branding For Viindoo",
'name_vi_VN': "Giao diện Viindoo cho module 2FA Invite mail",

'summary': """
Theme branding Viindoo for module 2FA Invite mail""",
'summary_vi_VN': """
Giao diện brand Viindoo cho module 2FA Invite mail
""",

'description': """
What it does
============
This module will change module 2FA Invite mail following Viindoo's brand


Editions Supported
==================
1. Community Edition
2. Enterprise Edition

""",

'description_vi_VN': """
Ứng dụng này làm gì
===================
Module này sẽ thay đổi module 2FA Invite mail theo thương hiệu Viindoo


Ấn bản được Hỗ trợ
==================
1. Ấn bản Community
2. Ấn bản Enterprise

""",

'author': "Viindoo",
'website': "https://viindoo.com",
'live_test_url': "https://v15demo-int.viindoo.com",
'live_test_url_vi_VN': "https://v15demo-vn.viindoo.com",
'support': "[email protected]",

# Categories can be used to filter modules in modules listing
# Check https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/data/ir_module_category_data.xml
# for the full list
'category': 'Hidden',
'version': '0.1',

# any module necessary for this one to work correctly
'depends': ['auth_totp_mail'],

# always loaded
'data': [
'data/mail_template_data.xml',
],
'installable': True,
'application': False,
'auto_install': True,
'price': 0.0,
'currency': 'EUR',
'license': 'OPL-1',
}
24 changes: 24 additions & 0 deletions viin_brand_auth_totp_mail/data/mail_template_data.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': False}" />
</function>

<function name="write" model="mail.template">
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" />
<value
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" />
</function>

<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': True}" />
</function>
Comment on lines +3 to +23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duyquyen96 anh thấy thì chỉ cần như này là đủ, để chỉ ghi đè 1 lần khi cài module này lên, những lần sau upgrade sẽ không bị
nếu làm như của em, mỗi lần upgrade đều ghi đè lại, giả xử khách sửa subject thành 1 cái khác, nâng cấp module sẽ lại bị sửa => chưa đúng ý nghĩa của noupdate
kiểm tra cả dịch nữa nhé

Suggested change
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': False}" />
</function>
<function name="write" model="mail.template">
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" />
<value
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" />
</function>
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': True}" />
</function>
<data noupdate="1">
<record id="auth_totp_mail.mail_template_totp_invite" model="mail.template">
<field name="subject">Invitation to activate two-factor authentication on your Viindoo account</field>
</record>
</data>

</odoo>