-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp* #358
base: 16.0
Are you sure you want to change the base?
Conversation
@duyquyen96 Viindoo Test Suite has failed! |
@duyquyen96 Viindoo Test Suite has failed! |
@viinbot rebase |
@duyquyen96 PR rebased! |
@viinbot rebuild |
@duyquyen96 PR in the queue to wait for rebuild! |
@duyquyen96 Viindoo Test Suite has passed! |
@viinbot rebase |
@davidtranhp PR rebased! |
c4cdf8c
to
3429328
Compare
@duyquyen96 Viindoo Test Suite has passed! |
<function name="write" model="ir.model.data"> | ||
<function name="search" model="ir.model.data"> | ||
<value | ||
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | ||
</function> | ||
<value eval="{'noupdate': False}" /> | ||
</function> | ||
|
||
<function name="write" model="mail.template"> | ||
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" /> | ||
<value | ||
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" /> | ||
</function> | ||
|
||
<function name="write" model="ir.model.data"> | ||
<function name="search" model="ir.model.data"> | ||
<value | ||
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | ||
</function> | ||
<value eval="{'noupdate': True}" /> | ||
</function> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duyquyen96 anh thấy thì chỉ cần như này là đủ, để chỉ ghi đè 1 lần khi cài module này lên, những lần sau upgrade sẽ không bị
nếu làm như của em, mỗi lần upgrade đều ghi đè lại, giả xử khách sửa subject thành 1 cái khác, nâng cấp module sẽ lại bị sửa => chưa đúng ý nghĩa của noupdate
kiểm tra cả dịch nữa nhé
<function name="write" model="ir.model.data"> | |
<function name="search" model="ir.model.data"> | |
<value | |
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | |
</function> | |
<value eval="{'noupdate': False}" /> | |
</function> | |
<function name="write" model="mail.template"> | |
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" /> | |
<value | |
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" /> | |
</function> | |
<function name="write" model="ir.model.data"> | |
<function name="search" model="ir.model.data"> | |
<value | |
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | |
</function> | |
<value eval="{'noupdate': True}" /> | |
</function> | |
<data noupdate="1"> | |
<record id="auth_totp_mail.mail_template_totp_invite" model="mail.template"> | |
<field name="subject">Invitation to activate two-factor authentication on your Viindoo account</field> | |
</record> | |
</data> |
Screen.Recording.2023-06-15.at.11.07.12.mov
I confirm I have read guidelines at https://docs.google.com/document/d/1Ru1C9XK93BNmXX1nKvTMt63QMBIOBy2NSdKosEwvuy4/edit