Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp* #358

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

duyquyen96
Copy link
Contributor

Screen.Recording.2023-06-15.at.11.07.12.mov

Screenshot 2023-06-15 at 11 27 19


I confirm I have read guidelines at https://docs.google.com/document/d/1Ru1C9XK93BNmXX1nKvTMt63QMBIOBy2NSdKosEwvuy4/edit

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 15, 2023
@viinbot
Copy link
Contributor

viinbot commented Jun 15, 2023

@duyquyen96 Viindoo Test Suite has failed!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 16, 2023
@viinbot
Copy link
Contributor

viinbot commented Jun 16, 2023

@duyquyen96 Viindoo Test Suite has failed!

@duyquyen96
Copy link
Contributor Author

@viinbot rebase

@viinbot
Copy link
Contributor

viinbot commented Jun 16, 2023

@duyquyen96 PR rebased!

@duyquyen96
Copy link
Contributor Author

@viinbot rebuild

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed ⚠️ Failed PR/Commit is failed when run script labels Jun 16, 2023
@viinbot
Copy link
Contributor

viinbot commented Jun 16, 2023

@duyquyen96 PR in the queue to wait for rebuild!

@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 16, 2023
@viinbot
Copy link
Contributor

viinbot commented Jun 16, 2023

@duyquyen96 Viindoo Test Suite has passed!

@duyquyen96 duyquyen96 changed the base branch from master to 16.0 July 12, 2023 11:02
@davidtranhp
Copy link
Contributor

@viinbot rebase

@viinbot
Copy link
Contributor

viinbot commented Jul 20, 2023

@davidtranhp PR rebased!

@viinbot viinbot force-pushed the v16_imp_viin_brand_auth_totp branch from c4cdf8c to 3429328 Compare July 20, 2023 09:00
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚀 Queue PR/Commit is added in build queue labels Jul 20, 2023
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Building PR/Commit is start building all step in script 🚀 Queue PR/Commit is added in build queue labels Sep 5, 2023
@viinbot
Copy link
Contributor

viinbot commented Sep 5, 2023

@duyquyen96 Viindoo Test Suite has passed!

Comment on lines +3 to +23
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': False}" />
</function>

<function name="write" model="mail.template">
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" />
<value
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" />
</function>

<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': True}" />
</function>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duyquyen96 anh thấy thì chỉ cần như này là đủ, để chỉ ghi đè 1 lần khi cài module này lên, những lần sau upgrade sẽ không bị
nếu làm như của em, mỗi lần upgrade đều ghi đè lại, giả xử khách sửa subject thành 1 cái khác, nâng cấp module sẽ lại bị sửa => chưa đúng ý nghĩa của noupdate
kiểm tra cả dịch nữa nhé

Suggested change
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': False}" />
</function>
<function name="write" model="mail.template">
<value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" />
<value
eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" />
</function>
<function name="write" model="ir.model.data">
<function name="search" model="ir.model.data">
<value
eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" />
</function>
<value eval="{'noupdate': True}" />
</function>
<data noupdate="1">
<record id="auth_totp_mail.mail_template_totp_invite" model="mail.template">
<field name="subject">Invitation to activate two-factor authentication on your Viindoo account</field>
</record>
</data>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Running PR/Commit is done for everything and ready for manually test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants