[refactor] HotkeyCombinationブランド型を導入 #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
changed the title
sevenc-nanashi
approved these changes
Feb 22, 2024
romot-co
pushed a commit
that referenced
this pull request
Mar 3, 2024
Hiroshiba
added a commit
that referenced
this pull request
Mar 16, 2024
* #1864 ノートのエラー時にツールチップを表示する * Update src/components/Sing/SequencerNote.vue Co-authored-by: Hiroshiba <[email protected]> * Update src/components/Sing/SequencerNote.vue Co-authored-by: Hiroshiba <[email protected]> * Update src/components/Sing/SequencerNote.vue Co-authored-by: Hiroshiba <[email protected]> --------- Co-authored-by: Romot <[email protected]> Co-authored-by: Hiroshiba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
HotkeyのCombinationはただのstringなのですが、型がついてないとちょっと不安だったのでブランド型を作ってみました。
のタスクでhotkeys-js用の型に変換するための布石でもあります。
関連 Issue
ref #1862
ref #1822
その他