Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ショートカットキーとしてCommandキーを使えるようにする #1865

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

Hiroshiba
Copy link
Member

内容

の解決PRです。

関連 Issue

fix #1862

その他

先に #1864 が必要ですが、最初の2コミットを除けば一応レビュー可能かもです。

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おおよそLGTMです!
コンフリクトがあったので、解消しておきました!

2点、気になる点があったので、コメントしてみました。

src/plugins/hotkeyPlugin.ts Outdated Show resolved Hide resolved
src/plugins/hotkeyPlugin.ts Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member Author

@y-chan 変更しました!

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
コメントも端的でわかりやすいと思います...!

Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージします!

hotkeys-js周りの実装をしてくださった @sevenc-nanashi さんにも共有まで!

@Hiroshiba Hiroshiba merged commit cc2bceb into VOICEVOX:main Feb 29, 2024
9 checks passed
@Hiroshiba Hiroshiba deleted the cmdを使えるようにする branch February 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hostkeys-jsに変更した影響でmacOSでCmdを使ったショートカットが使えなくなっている
2 participants