chore: build_optsを整理する
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Aug 15, 2024
qryxip
force-pushed
the
chore-refine-build-opts
branch
from
cb2f54f to
3be316e
Compare
|
|
Hiroshiba
approved these changes
Aug 16, 2024
| python ./tools/ci_build/build.py --build_dir ./build ${{ matrix.build_opts }} ${{ matrix.build_opts_workaround_protoc }} | ||
|
|
||
| build_opts=( | ||
| ${{ matrix.build_opts }} |
There was a problem hiding this comment.
（ただのコメントです）
matrix.build_optsはbashの配列構文？の中に入るもの、というのが名前から分からないのをどうにかできないかとちょっとだけ思いました！
でもいいのが思いつかなかった。。build_ops_bash_arrayとか･･･？
思いつかないのでこのままでも良さそう！
There was a problem hiding this comment.
正直ここのmatrix自体、名前-値のペアだけでその機能を推測するのが大体困難なので後で全部まとめてコメントを書くというのはどうでしょうか？こんな風に:
https://github.com/VOICEVOX/voicevox_core/blob/d6765462fd246d22306a7badd438d34745345231/.github/workflows/build_and_deploy.yml#L44-L51
There was a problem hiding this comment.
たしかに！
１行だけで説明するのは難しいのも結構ありそうな気がしますしねぇ･･･。
とりあえず今の形でも問題ないとは思うので、一旦マージしますか！！
コメント追加はたぶんしたほうが良いと思うので、もしよければ追加PRいただければということで･･･！ 🙏
Co-authored-by: Hiroshiba <[email protected]>
|
マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
build_optsの整理をします。|-を使った複数行の記述方式にし、#でコメントも加えられるようにするモチベーションとしては、このリポジトリの秘伝のタレ化を少しでも防ぐためです。
関連 Issue
スクリーンショット・動画など
その他