Skip to content

Commit

Permalink
[skip ci] CMAKE_SYSTEM_{NAME,PROCESSOR}に関するコメントを更新
Browse files Browse the repository at this point in the history
  • Loading branch information
qryxip committed Aug 16, 2024
1 parent 87657a9 commit cb2f54f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -365,10 +365,9 @@ jobs:
- name: Build ONNX Runtime
if: steps.cache-build-result.outputs.cache-hit != 'true'
run: |
# TODO: ↓ この記述は VOICEVOX/voicevox_core#41 時点でのarmhfビルドに対するもの。`CMAKE_SYSTEM_{NAME,CMAKE_SYSTEM_PROCESSOR}`が必要のないケースが多いはず。例えばv1.17時点では、AndroidとiOSのビルドではcpuinfoのケアまでちゃんとされているはず。
# add --arm for gcc-8: https://github.com/microsoft/onnxruntime/issues/4189
# skip test: https://github.com/microsoft/onnxruntime/issues/2436
#
# TODO: ↓ 今のONNX Runtimeなら別に設定しなくてもいいのではないか?
# ONNX Runtime v1.9.0 requires CMAKE_SYSTEM_PROCESSOR, https://github.com/microsoft/onnxruntime/releases/tag/v1.9.0
# Both CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR are required.
Expand Down

0 comments on commit cb2f54f

Please sign in to comment.